Merge pull request #15580 from piotracalski/piotracalski-gh15579

Bugfix: `Model.validate()` hangs when all paths fail casting

Author: vkarpov15

lib/model.js

@@ -4304,6 +4304,10 @@ Model.validate = async function validate(obj, pathsOrOptions, context) {
   let remaining = paths.size;
 
   return new Promise((resolve, reject) => {
+    if (remaining === 0) {
+      return settle();
+    }
+
     for (const path of paths) {
       const schemaType = schema.path(path);
       if (schemaType == null) {
@@ -4328,13 +4332,17 @@ Model.validate = async function validate(obj, pathsOrOptions, context) {
       }, context, { path: path });
     }
 
+    function settle() {
+      if (error) {
+        reject(error);
+      } else {
+        resolve(obj);
+      }
+    }
+
     function _checkDone() {
       if (--remaining <= 0) {
-        if (error) {
-          reject(error);
-        } else {
-          resolve(obj);
-        }
+        return settle();
       }
     }
   });

test/model.validate.test.js

@@ -206,4 +206,28 @@ describe('model: validate: ', function() {
     assert.equal(err.errors['myNumber'].name, 'CastError');
     assert.equal(err.errors['invalid1'].name, 'ValidatorError');
   });
+
+  it('should return cast errors when validating only paths that fail casting', async function() {
+    const Model = mongoose.model('Test', new Schema({
+      validPath: {
+        type: String,
+        required: true
+      },
+      invalidPath1: {
+        type: Number,
+        required: true
+      },
+      invalidPath2: {
+        type: Number,
+        required: true
+      }
+    }));
+
+    const err = await Model.validate({ validPath: 'foo', invalidPath1: 'not a number', invalidPath2: 'not a number' }, ['invalidPath1', 'invalidPath2']).
+      then(() => null, err => err);
+    assert.ok(err);
+    assert.deepEqual(Object.keys(err.errors).sort(), ['invalidPath1', 'invalidPath2']);
+    assert.equal(err.errors['invalidPath1'].name, 'CastError');
+    assert.equal(err.errors['invalidPath2'].name, 'CastError');
+  });
 });