Skip to content

feat: only wrap walltime command with sudo on linux#314

Merged
GuillaumeLagrange merged 2 commits into
mainfrom
cod-2558-macos-demo-issues
Apr 24, 2026
Merged

feat: only wrap walltime command with sudo on linux#314
GuillaumeLagrange merged 2 commits into
mainfrom
cod-2558-macos-demo-issues

Conversation

@GuillaumeLagrange

@GuillaumeLagrange GuillaumeLagrange commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

We do not yet need sudo, since we don't use launchtl nor profilers yet.

image

@codspeed-hq

codspeed-hq Bot commented Apr 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-2558-macos-demo-issues (bd91957) with main (7917f2c)

Open in CodSpeed

@GuillaumeLagrange
GuillaumeLagrange marked this pull request as ready for review April 24, 2026 13:41

@not-matthias not-matthias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-2558-macos-demo-issues branch from 94314cc to bb4c353 Compare April 24, 2026 14:09
@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-2558-macos-demo-issues branch from bb4c353 to bd91957 Compare April 24, 2026 15:44
@GuillaumeLagrange
GuillaumeLagrange merged commit bd91957 into main Apr 24, 2026
18 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the cod-2558-macos-demo-issues branch April 24, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants