You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
description: Run the full code quality gate for the giskard-oss monorepo—format, lint, typecheck, and unit tests across all packages. Use when finishing a feature, before opening a PR, or when the user asks to check quality or run the gate.
4
+
disable-model-invocation: true
5
+
allowed-tools: Bash(make *)
6
+
---
7
+
8
+
# giskard-oss — quality gate
9
+
10
+
## Results
11
+
12
+
```!
13
+
echo "=== make format ===" && make format 2>&1 | tail -5
14
+
echo "=== make check ===" && make check 2>&1 | tail -10
15
+
echo "=== make test-unit PACKAGE=giskard-core ===" && make test-unit PACKAGE=giskard-core 2>&1 | tail -5
16
+
echo "=== make test-unit PACKAGE=giskard-checks ===" && make test-unit PACKAGE=giskard-checks 2>&1 | tail -5
17
+
echo "=== make test-unit PACKAGE=giskard-agents ===" && make test-unit PACKAGE=giskard-agents 2>&1 | tail -5
18
+
```
19
+
20
+
Report pass/fail for each step. Fix root causes on failure — no `# type: ignore`, no skips. Re-run after fixing.
Copy file name to clipboardExpand all lines: .cursor/rules/guidelines.mdc
+13Lines changed: 13 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -15,3 +15,16 @@ Do not remove unrelated code, functionalities, or comments without explicit reas
15
15
## No CODEMAP
16
16
17
17
Never generate architecture maps, codemap files, or similar high-maintenance documentation that duplicates what is already in cursor rules, docstrings, and README. These files go stale fast and create maintenance burden.
18
+
19
+
## Root Causes, No Temporary Fixes
20
+
21
+
Trace failures to their source before making a change. Do not:
22
+
- Add `# type: ignore` / `# pyright: ignore` without first confirming no structural fix is possible.
23
+
- Modify test assertions to force a pass — if a test reveals a real bug, fix the bug.
24
+
- Add `try/except` to suppress exceptions that should be fixed.
25
+
26
+
If the root cause is in a different library than where the symptom appears, say so before proposing a fix.
27
+
28
+
## Minimal Scope
29
+
30
+
Only touch files directly required by the task. Do not reformat untouched lines, rename unrelated variables, or add type annotations to code you didn't otherwise change. Propose nearby improvements separately and wait for approval.
Copy file name to clipboardExpand all lines: .cursor/skills/giskard-oss-pr-ready/SKILL.md
+10Lines changed: 10 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -48,6 +48,16 @@ If checks fail from missing tools, run **`make install`** and **`make install-to
48
48
49
49
Use valid shell assignments in `.env` (e.g. `GEMINI_API_KEY=...`). If you point `TEST_MODEL` / `TEST_EMBEDDING_MODEL` at another provider, add whatever API keys that provider expects (LiteLLM / the underlying SDK).
50
50
51
+
## Verification gate
52
+
53
+
Before declaring a branch merge-ready, include the following evidence in your response:
54
+
55
+
1. Last line(s) of `make check` output — must show no errors.
56
+
2. Pytest summary from `make test-unit` — e.g. `52 passed, 0 failed`.
57
+
3. If any step was skipped or failed, state it explicitly.
58
+
59
+
"It should pass" is not evidence. Show actual output.
60
+
51
61
## Library-specific rules
52
62
53
63
For package conventions (API patterns, tests layout), read `libs/<package>/.cursor/rules/`. Makefile targets are always invoked from the repository root as listed above.
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -19,16 +19,16 @@
19
19
20
20
## Coding agents
21
21
22
-
If this PR was opened by or with a coding agent, read **[AGENTS.md](https://github.com/Giskard-AI/giskard-oss/blob/main/AGENTS.md)**at the repository root first — **it is required** (setup, `make` commands, expedited agent PR workflow, etc.).
22
+
Autonomous agents with no human in the loop must read **[AUTONOMOUS.md](https://github.com/Giskard-AI/giskard-oss/blob/main/AUTONOMOUS.md)**before opening a PR.
23
23
24
24
**PR title:** agent-opened PRs **must** end the title with **`🤖🤖🤖🤖`** (exactly four robot emojis). Do not omit — that suffix is how the expedited agent PR workflow picks up the PR.
25
25
26
26
## Checklist
27
27
28
28
<!-- Mark with an `x` all the checkboxes that apply (like `[x]`) -->
29
29
30
-
-[ ] I've read the [`CODE_OF_CONDUCT.md`](https://github.com/Giskard-AI/ai-inspector/blob/master/CODE_OF_CONDUCT.md) document.
31
-
-[ ] I've read the [`CONTRIBUTING.md`](https://github.com/Giskard-AI/ai-inspector/blob/master/CONTRIBUTING.md) guide.
30
+
-[ ] I've read the [`CODE_OF_CONDUCT.md`](../CODE_OF_CONDUCT.md) document.
31
+
-[ ] I've read the [`CONTRIBUTING.md`](../CONTRIBUTING.md) guide.
32
32
-[ ] I've written tests for all new methods and classes that I created.
33
33
-[ ] I've written the docstring in NumPy format for all the methods and classes that I created or modified.
34
34
-[ ] I've updated the `uv.lock` running `uv lock` (only applicable when `pyproject.toml` has been
0 commit comments