Skip to content

Commit 947a9cb

Browse files
committed
🎨 Language / menu cleanup
1 parent 62487c6 commit 947a9cb

30 files changed

+102
-110
lines changed

Marlin/src/lcd/e3v2/proui/dwin.cpp

Lines changed: 78 additions & 54 deletions
Large diffs are not rendered by default.

Marlin/src/lcd/e3v2/proui/dwin.h

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ static constexpr size_t eeprom_data_size = sizeof(HMI_data_t);
141141

142142
typedef struct {
143143
int8_t Color[3]; // Color components
144-
TERN_(HAS_PID_HEATING, pidresult_t pidresult = PID_DONE);
144+
#if HAS_PID_HEATING
145+
tempcontrol_t pidresult = PID_DONE;
146+
#endif
145147
uint8_t Select = 0; // Auxiliary selector variable
146148
AxisEnum axis = X_AXIS; // Axis Select
147149
} HMI_value_t;
@@ -213,10 +215,10 @@ void ParkHead();
213215
void ApplyLEDColor();
214216
#endif
215217
#if ENABLED(AUTO_BED_LEVELING_UBL)
216-
void UBLTiltMesh();
218+
void UBLMeshTilt();
217219
bool UBLValidMesh();
218-
void UBLSaveMesh();
219-
void UBLLoadMesh();
220+
void UBLMeshSave();
221+
void UBLMeshLoad();
220222
#endif
221223
#if ENABLED(HOST_SHUTDOWN_MENU_ITEM) && defined(SHUTDOWN_ACTION)
222224
void HostShutDown();
@@ -356,10 +358,13 @@ void Draw_Steps_Menu();
356358
#endif
357359

358360
// PID
359-
void DWIN_PidTuning(pidresult_t result);
360-
#if ENABLED(PIDTEMP)
361-
void Draw_HotendPID_Menu();
361+
#if HAS_PID_HEATING
362+
void DWIN_PidTuning(tempcontrol_t result);
363+
#if ENABLED(PIDTEMP)
364+
void Draw_HotendPID_Menu();
365+
#endif
366+
#if ENABLED(PIDTEMPBED)
367+
void Draw_BedPID_Menu();
368+
#endif
362369
#endif
363-
#if ENABLED(PIDTEMPBED)
364-
void Draw_BedPID_Menu();
365370
#endif

Marlin/src/lcd/e3v2/proui/dwinui.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,14 +138,12 @@
138138
#define ICON_UBLActive ICON_HotendTemp
139139
#define ICON_UBLActive ICON_HotendTemp
140140
#define ICON_UBLSlot ICON_ResumeEEPROM
141-
#define ICON_UBLSaveMesh ICON_WriteEEPROM
142-
#define ICON_UBLLoadMesh ICON_ReadEEPROM
141+
#define ICON_UBLMeshSave ICON_WriteEEPROM
142+
#define ICON_UBLMeshLoad ICON_ReadEEPROM
143143
#define ICON_UBLTiltGrid ICON_PrintSize
144144
#define ICON_UBLSmartFill ICON_StockConfiguration
145145
#define ICON_ZAfterHome ICON_SetEndTemp
146146

147-
148-
149147
#define ICON_CaseLight ICON_Motion
150148
#define ICON_LedControl ICON_Motion
151149

Marlin/src/lcd/language/language_an.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ namespace Language_an {
103103
LSTR MSG_FLOW_N = _UxGT("Fluxo ~");
104104
LSTR MSG_CONTROL = _UxGT("Control");
105105
LSTR MSG_AUTOTEMP = _UxGT("Temperatura Auto.");
106-
LSTR MSG_SELECT = _UxGT("Trigar");
107106
LSTR MSG_SELECT_E = _UxGT("Trigar *");
108107
LSTR MSG_ACC = _UxGT("Aceleracion");
109108
LSTR MSG_VTRAV_MIN = _UxGT("Vel. viache min");

Marlin/src/lcd/language/language_cz.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ namespace Language_cz {
264264
LSTR MSG_LCD_OFF = _UxGT("Vyp");
265265
LSTR MSG_PID_AUTOTUNE = _UxGT("PID automatika");
266266
LSTR MSG_PID_AUTOTUNE_E = _UxGT("PID automatika *");
267-
LSTR MSG_SELECT = _UxGT("Vybrat");
268267
LSTR MSG_SELECT_E = _UxGT("Vybrat *");
269268
LSTR MSG_ACC = _UxGT("Zrychl");
270269
LSTR MSG_JERK = _UxGT("Jerk");

Marlin/src/lcd/language/language_da.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ namespace Language_da {
9898
LSTR MSG_AUTOTEMP = _UxGT("Autotemp");
9999
LSTR MSG_LCD_ON = _UxGT("Til");
100100
LSTR MSG_LCD_OFF = _UxGT("Fra");
101-
LSTR MSG_SELECT = _UxGT("Vælg");
102101
LSTR MSG_SELECT_E = _UxGT("Vælg *");
103102
LSTR MSG_A_RETRACT = _UxGT("A-retract");
104103
LSTR MSG_A_TRAVEL = _UxGT("A-rejse");

Marlin/src/lcd/language/language_de.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,6 @@ namespace Language_de {
357357
LSTR MSG_SENSOR_RESPONSIVENESS_E = _UxGT("Sensor res *");
358358
LSTR MSG_MPC_AMBIENT_XFER_COEFF_E = _UxGT("Ambient h *");
359359
LSTR MSG_MPC_AMBIENT_XFER_COEFF_FAN_E = _UxGT("Amb. h fan *");
360-
LSTR MSG_SELECT = _UxGT("Auswählen");
361360
LSTR MSG_SELECT_E = _UxGT("Auswählen *");
362361
LSTR MSG_ACC = _UxGT("Beschleunigung");
363362
LSTR MSG_JERK = _UxGT("Jerk");

Marlin/src/lcd/language/language_en.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,6 @@ namespace Language_en {
378378
LSTR MSG_SENSOR_RESPONSIVENESS_E = _UxGT("Sensor res *");
379379
LSTR MSG_MPC_AMBIENT_XFER_COEFF_E = _UxGT("Ambient h *");
380380
LSTR MSG_MPC_AMBIENT_XFER_COEFF_FAN_E = _UxGT("Amb. h fan *");
381-
LSTR MSG_SELECT = _UxGT("Select");
382381
LSTR MSG_SELECT_E = _UxGT("Select *");
383382
LSTR MSG_ACC = _UxGT("Accel");
384383
LSTR MSG_JERK = _UxGT("Jerk");
@@ -553,11 +552,11 @@ namespace Language_en {
553552
LSTR MSG_TOOL_MIGRATION_END = _UxGT("Last Extruder");
554553
LSTR MSG_TOOL_MIGRATION_SWAP = _UxGT("Migrate to *");
555554
LSTR MSG_FILAMENTCHANGE = _UxGT("Change Filament");
556-
LSTR MSG_FILAMENTCHANGE_E = _UxGT("Change Filament *");
555+
LSTR MSG_FILAMENTCHANGE_E = _UxGT("Change * Filament");
557556
LSTR MSG_FILAMENTLOAD = _UxGT("Load Filament");
558-
LSTR MSG_FILAMENTLOAD_E = _UxGT("Load *");
557+
LSTR MSG_FILAMENTLOAD_E = _UxGT("Load * Filament");
559558
LSTR MSG_FILAMENTUNLOAD = _UxGT("Unload Filament");
560-
LSTR MSG_FILAMENTUNLOAD_E = _UxGT("Unload *");
559+
LSTR MSG_FILAMENTUNLOAD_E = _UxGT("Unload * Filament");
561560
LSTR MSG_FILAMENTUNLOAD_ALL = _UxGT("Unload All");
562561
#if ENABLED(MULTI_VOLUME)
563562
LSTR MSG_ATTACH_MEDIA = _UxGT("Attach SD Card");

Marlin/src/lcd/language/language_es.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ namespace Language_es {
265265
LSTR MSG_LCD_OFF = _UxGT("Apg");
266266
LSTR MSG_PID_AUTOTUNE = _UxGT("PID Auto-ajuste");
267267
LSTR MSG_PID_AUTOTUNE_E = _UxGT("PID Auto-ajuste *");
268-
LSTR MSG_SELECT = _UxGT("Seleccionar");
269268
LSTR MSG_SELECT_E = _UxGT("Seleccionar *");
270269
LSTR MSG_ACC = _UxGT("Aceleración");
271270
LSTR MSG_JERK = _UxGT("Jerk");

Marlin/src/lcd/language/language_eu.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ namespace Language_eu {
161161
LSTR MSG_MAX = " " LCD_STR_THERMOMETER _UxGT(" Max");
162162
LSTR MSG_FACTOR = " " LCD_STR_THERMOMETER _UxGT(" Fakt");
163163
LSTR MSG_AUTOTEMP = _UxGT("Auto tenperatura");
164-
LSTR MSG_SELECT = _UxGT("Aukeratu");
165164
LSTR MSG_SELECT_E = _UxGT("Aukeratu *");
166165
LSTR MSG_ACC = _UxGT("Azelerazioa");
167166
LSTR MSG_JERK = _UxGT("Astindua");

0 commit comments

Comments
 (0)