Fix type-stability

gdalle · gdalle · commit 1dd6e746e270 · 2025-08-16T17:35:32.000+02:00
diff --git a/ext/ImplicitDifferentiationForwardDiffExt.jl b/ext/ImplicitDifferentiationForwardDiffExt.jl
@@ -22,10 +22,10 @@ function (implicit::ImplicitFunction)(
     suggested_backend = AutoForwardDiff()
     A = build_A(implicit, prep, x, y, z, c, args...; suggested_backend)
     B = build_B(implicit, prep, x, y, z, c, args...; suggested_backend)
-    if linear_solver isa IterativeLeastSquaresSolver
-        Aᵀ = build_Aᵀ(implicit, prep, x, y, z, c, args...; suggested_backend)
+    Aᵀ = if linear_solver isa IterativeLeastSquaresSolver
+        build_Aᵀ(implicit, prep, x, y, z, c, args...; suggested_backend)
     else
-        Aᵀ = nothing
+        nothing
     end
 
     dX = ntuple(k -> partials.(x_and_dx, k), Val(N))
diff --git a/test/systematic.jl b/test/systematic.jl
@@ -28,7 +28,6 @@ end;
         [
             IterativeLinearSolver(),
             IterativeLinearSolver(; rtol=1e-8),
-            IterativeLinearSolver(; issymmetric=true, isposdef=true),
             IterativeLeastSquaresSolver(),
         ],
         [nothing, (; x=AutoForwardDiff(), y=AutoZygote())],

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ end;`
`28`	`28`	`[`
`29`	`29`	`IterativeLinearSolver(),`
`30`	`30`	`IterativeLinearSolver(; rtol=1e-8),`
`31`		`- IterativeLinearSolver(; issymmetric=true, isposdef=true),`
`32`	`31`	`IterativeLeastSquaresSolver(),`
`33`	`32`	`],`
`34`	`33`	`[nothing, (; x=AutoForwardDiff(), y=AutoZygote())],`