Skip to content

Commit 1acebc3

Browse files
committed
Fix macOS build and improve Python wheel configuration
macOS fixes: - Make PCL installation optional on macOS (can be problematic) - Allow build to continue if PCL fails to install Python wheel fixes: - Add CMAKE_POSITION_INDEPENDENT_CODE=ON for shared library builds - Keep bundled dependencies approach for wheel builds This should resolve macOS C++ build failures while maintaining successful Ubuntu builds.
1 parent 4a30dbb commit 1acebc3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/ci-cpp.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ jobs:
6666
tbb \
6767
lz4 \
6868
flann \
69-
pcl \
7069
git
70+
# PCL can be problematic on macOS, try to install it separately
71+
brew install pcl || echo "PCL installation failed, will use bundled version"
7172
7273
- name: Setup MSVC (Windows)
7374
if: runner.os == 'Windows'

python/pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,6 @@ cmake.args = [
5151
"-DUSE_SYSTEM_ROBIN=OFF"
5252
]
5353
cmake.define = {
54-
CMAKE_CXX_STANDARD = "17"
54+
CMAKE_CXX_STANDARD = "17",
55+
CMAKE_POSITION_INDEPENDENT_CODE = "ON"
5556
}

0 commit comments

Comments
 (0)