Skip to content

Commit 0f7fb5d

Browse files
committed
πŸ§‘β€πŸ’» Media conditionals
1 parent 428f721 commit 0f7fb5d

35 files changed

+65
-61
lines changed

β€ŽMarlin/src/HAL/RP2040/inc/SanityCheck.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
// #error "SPINDLE_LASER_PWM_PIN must use SERVO0, SERVO1 or SERVO3 connector"
2929
//#endif
3030

31-
#if ENABLED(SDCARD_EEPROM_EMULATION) && DISABLED(SDSUPPORT)
31+
#if ENABLED(SDCARD_EEPROM_EMULATION) && !HAS_MEDIA
3232
#undef SDCARD_EEPROM_EMULATION // Avoid additional error noise
3333
#if USE_FALLBACK_EEPROM
3434
#warning "EEPROM type not specified. Fallback is SDCARD_EEPROM_EMULATION."

β€ŽMarlin/src/HAL/RP2040/msc_sd.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
class Sd2CardUSBMscHandler : public USBMscHandler {
4343
public:
4444
DiskIODriver* diskIODriver() {
45-
#if ENABLED(MULTI_VOLUME)
45+
#if HAS_MULTI_VOLUME
4646
#if SHARED_VOLUME_IS(SD_ONBOARD)
4747
return &card.media_driver_sdcard;
4848
#elif SHARED_VOLUME_IS(USB_FLASH_DRIVE)

β€ŽMarlin/src/HAL/STM32/inc/SanityCheck.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
* Check for common serial pin conflicts
5959
*/
6060
#define _CHECK_SERIAL_PIN(N) (( \
61-
BTN_EN1 == N || BTN_EN2 == N ||DOGLCD_CS == N || HEATER_BED_PIN == N || FAN0_PIN == N || \
61+
BTN_EN1 == N || BTN_EN2 == N || DOGLCD_CS == N || HEATER_BED_PIN == N || FAN0_PIN == N || \
6262
SDIO_D2_PIN == N || SDIO_D3_PIN == N || SDIO_CK_PIN == N || SDIO_CMD_PIN == N || \
6363
Y_STEP_PIN == N || Y_ENABLE_PIN == N || E0_ENABLE_PIN == N || POWER_LOSS_PIN == N \
6464
))

β€ŽMarlin/src/HAL/STM32/msc_sd.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
class Sd2CardUSBMscHandler : public USBMscHandler {
5050
public:
5151
DiskIODriver* diskIODriver() {
52-
#if ENABLED(MULTI_VOLUME)
52+
#if HAS_MULTI_VOLUME
5353
#if SHARED_VOLUME_IS(SD_ONBOARD)
5454
return &card.media_driver_sdcard;
5555
#elif SHARED_VOLUME_IS(USB_FLASH_DRIVE)

β€ŽMarlin/src/MarlinCore.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ void idle(const bool no_stepper_sleep/*=false*/) {
815815
TERN_(HAS_MEDIA, card.manage_media());
816816

817817
// Handle USB Flash Drive insert / remove
818-
TERN_(USB_FLASH_DRIVE_SUPPORT, card.diskIODriver()->idle());
818+
TERN_(HAS_USB_FLASH_DRIVE, card.diskIODriver()->idle());
819819

820820
// Announce Host Keepalive state (if any)
821821
TERN_(HOST_KEEPALIVE_FEATURE, gcode.host_keepalive());

β€ŽMarlin/src/gcode/host/M115.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ void GcodeSuite::M115() {
194194

195195
// MULTI_VOLUME (M21 S/M21 U)
196196
#if HAS_MEDIA
197-
cap_line(F("MULTI_VOLUME"), ENABLED(MULTI_VOLUME));
197+
cap_line(F("MULTI_VOLUME"), ENABLED(HAS_MULTI_VOLUME));
198198
#endif
199199

200200
// REPEAT (M808)

β€ŽMarlin/src/gcode/parser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ void GCodeParser::parse(char *p) {
273273
// Only use string_arg for these M codes
274274
if (letter == 'M') switch (codenum) {
275275
TERN_(EXPECTED_PRINTER_CHECK, case 16:)
276-
TERN_(SDSUPPORT, case 23: case 28: case 30: case 928:)
276+
TERN_(HAS_MEDIA, case 23: case 28: case 30: case 928:)
277277
TERN_(HAS_STATUS_MESSAGE, case 117:)
278278
TERN_(HAS_RS485_SERIAL, case 485:)
279279
TERN_(GCODE_MACROS, case 810 ... 819:)

β€ŽMarlin/src/gcode/sd/M21_M22.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* P1 or U - Change to the USB Drive and mount it
3636
*/
3737
void GcodeSuite::M21() {
38-
#if ENABLED(MULTI_VOLUME)
38+
#if HAS_MULTI_VOLUME
3939
const int8_t vol = parser.intval('P', -1);
4040
if (vol == 0 || parser.seen_test('S')) // "S" for SD Card
4141
card.changeMedia(&card.media_driver_sdcard);

β€ŽMarlin/src/inc/Conditionals-2-LCD.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@
3636
#if ENABLED(SDSUPPORT)
3737
#define HAS_MEDIA 1
3838
#endif
39+
#if ENABLED(MULTI_VOLUME)
40+
#define HAS_MULTI_VOLUME 1
41+
#endif
42+
#if ENABLED(USB_FLASH_DRIVE_SUPPORT)
43+
#define HAS_USB_FLASH_DRIVE 1
44+
#endif
3945

4046
//
4147
// Serial Port Info

β€ŽMarlin/src/inc/Conditionals-4-adv.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1234,7 +1234,7 @@
12341234
#define HOMING_BUMP_MM { 0, 0, 0 }
12351235
#endif
12361236

1237-
#if ENABLED(USB_FLASH_DRIVE_SUPPORT) && NONE(USE_OTG_USB_HOST, USE_UHS3_USB)
1237+
#if HAS_USB_FLASH_DRIVE && NONE(USE_OTG_USB_HOST, USE_UHS3_USB)
12381238
#define USE_UHS2_USB
12391239
#endif
12401240

0 commit comments

Comments
Β (0)