Skip to content

Commit 585cbbb

Browse files
committed
🩹 Minor ExtUI/DGUS code fix/cleanup
1 parent fea7077 commit 585cbbb

File tree

9 files changed

+17
-33
lines changed

9 files changed

+17
-33
lines changed

Marlin/src/lcd/extui/anycubic_chiron/chiron_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,11 @@ namespace ExtUI {
7070
void onUserConfirmRequired(const char * const msg) { chiron.confirmationRequest(msg); }
7171

7272
// For fancy LCDs include an icon ID, message, and translated button title
73-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
73+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
7474
onUserConfirmRequired(cstr);
75-
UNUSED(icon); UNUSED(fBtn);
7675
}
77-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
76+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
7877
onUserConfirmRequired(fstr);
79-
UNUSED(icon); UNUSED(fBtn);
8078
}
8179

8280
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/anycubic_i3mega/anycubic_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,11 @@ namespace ExtUI {
5858
void onUserConfirmRequired(const char * const msg) { anycubicTFT.onUserConfirmRequired(msg); }
5959

6060
// For fancy LCDs include an icon ID, message, and translated button title
61-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
61+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
6262
onUserConfirmRequired(cstr);
63-
UNUSED(icon); UNUSED(fBtn);
6463
}
65-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
64+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
6665
onUserConfirmRequired(fstr);
67-
UNUSED(icon); UNUSED(fBtn);
6866
}
6967

7068
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/anycubic_vyper/vyper_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,11 @@ namespace ExtUI {
7070
void onUserConfirmRequired(const char * const msg) { dgus.confirmationRequest(msg); }
7171

7272
// For fancy LCDs include an icon ID, message, and translated button title
73-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
73+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
7474
onUserConfirmRequired(cstr);
75-
UNUSED(icon); UNUSED(fBtn);
7675
}
77-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
76+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
7877
onUserConfirmRequired(fstr);
79-
UNUSED(icon); UNUSED(fBtn);
8078
}
8179

8280
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/dgus_e3s1pro/dgus_e3s1pro_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,11 @@ namespace ExtUI {
8888
}
8989

9090
// For fancy LCDs include an icon ID, message, and translated button title
91-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
91+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
9292
onUserConfirmRequired(cstr);
93-
UNUSED(icon); UNUSED(fBtn);
9493
}
95-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
94+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
9695
onUserConfirmRequired(fstr);
97-
UNUSED(icon); UNUSED(fBtn);
9896
}
9997

10098
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/dgus_reloaded/DGUSRxHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ void DGUSRxHandler::probe(DGUS_VP &vp, void *data_ptr) {
503503
UNUSED(data_ptr);
504504

505505
#if ENABLED(MESH_BED_LEVELING)
506-
screen.setStatusMessage(FPSTR(DGUS_MSG_ABL_REQUIRED));
506+
screen.setStatusMessage(GET_TEXT_F(DGUS_MSG_ABL_REQUIRED));
507507
return;
508508
#endif
509509

Marlin/src/lcd/extui/dgus_reloaded/dgus_reloaded_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,11 @@ namespace ExtUI {
8383
}
8484

8585
// For fancy LCDs include an icon ID, message, and translated button title
86-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
86+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
8787
onUserConfirmRequired(cstr);
88-
UNUSED(icon); UNUSED(fBtn);
8988
}
90-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
89+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
9190
onUserConfirmRequired(fstr);
92-
UNUSED(icon); UNUSED(fBtn);
9391
}
9492

9593
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/ftdi_eve_touch_ui/ftdi_eve_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,11 @@ namespace ExtUI {
133133
#endif
134134

135135
// For fancy LCDs include an icon ID, message, and translated button title
136-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
136+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
137137
onUserConfirmRequired(cstr);
138-
UNUSED(icon); UNUSED(fBtn);
139138
}
140-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
139+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
141140
onUserConfirmRequired(fstr);
142-
UNUSED(icon); UNUSED(fBtn);
143141
}
144142

145143
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/ia_creality/ia_creality_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,11 @@ void onUserConfirmRequired(const char *const msg) {
233233
}
234234

235235
// For fancy LCDs include an icon ID, message, and translated button title
236-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
236+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
237237
onUserConfirmRequired(cstr);
238-
UNUSED(icon); UNUSED(fBtn);
239238
}
240-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
239+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
241240
onUserConfirmRequired(fstr);
242-
UNUSED(icon); UNUSED(fBtn);
243241
}
244242

245243
#if ENABLED(ADVANCED_PAUSE_FEATURE)

Marlin/src/lcd/extui/nextion/nextion_extui.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,11 @@ namespace ExtUI {
5656
void onUserConfirmRequired(const char * const msg) { nextion.confirmationRequest(msg); }
5757

5858
// For fancy LCDs include an icon ID, message, and translated button title
59-
void onUserConfirmRequired(const int icon, const char * const cstr, FSTR_P const fBtn) {
59+
void onUserConfirmRequired(const int, const char * const cstr, FSTR_P const) {
6060
onUserConfirmRequired(cstr);
61-
UNUSED(icon); UNUSED(fBtn);
6261
}
63-
void onUserConfirmRequired(const int icon, FSTR_P const fstr, FSTR_P const fBtn) {
62+
void onUserConfirmRequired(const int, FSTR_P const fstr, FSTR_P const) {
6463
onUserConfirmRequired(fstr);
65-
UNUSED(icon); UNUSED(fBtn);
6664
}
6765

6866
#if ENABLED(ADVANCED_PAUSE_FEATURE)

0 commit comments

Comments
 (0)