[MIG] hr_holidays_summary_email: Migration to 18.0

Author: BhaveshHeliconia

hr_holidays_summary_email/README.rst

@@ -77,6 +77,10 @@ Contributors
 
      - Jordi Masvidal
 
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
+
 Maintainers
 -----------
 

hr_holidays_summary_email/__manifest__.py

@@ -6,7 +6,7 @@
     "summary": """
         Notify employees with daily or weekly leaves summaries of their company.
     """,
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Human Resources",
     "website": "https://github.com/OCA/hr-holidays",
     "author": "ForgeFlow, Odoo Community Association (OCA)",

hr_holidays_summary_email/data/ir_cron.xml

@@ -6,8 +6,6 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">1</field>
         <field name="interval_type">days</field>
-        <field name="numbercall">-1</field>
-        <field eval="False" name="doall" />
         <field name="model_id" ref="model_hr_leave" />
         <field name="state">code</field>
         <field name="code">model._cron_send_hr_leave_summary_emails()</field>

hr_holidays_summary_email/readme/CONTRIBUTORS.md

@@ -1,3 +1,5 @@
 - ForgeFlow \<http://www.forgeflow.com\>
 
   > - Jordi Masvidal
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia

hr_holidays_summary_email/static/description/index.html

@@ -426,6 +426,11 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 </ul>
 </blockquote>
 </li>
+<li><p class="first"><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a></p>
+<ul class="simple">
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

hr_holidays_summary_email/tests/test_hr_leave_summary_email.py

@@ -4,10 +4,10 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo.tests import common
+from odoo.addons.base.tests.common import BaseCommon
 
 
-class TestHrLeaveSummaryEmail(common.TransactionCase):
+class TestHrLeaveSummaryEmail(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -16,17 +16,9 @@ def setUpClass(cls):
         # Add allocation days for the test
         leave_type.write({"requires_allocation": "no"})
         calendar = cls.env.ref("resource.resource_calendar_std")
-        partner = cls.env["res.partner"].create(
-            {
-                "name": "Test employee",
-                "type": "private",
-                "country_id": cls.env.ref("base.es").id,
-            }
-        )
         cls.employee = cls.env["hr.employee"].create(
             {
                 "name": "Test employee",
-                "address_home_id": partner.id,
                 "resource_calendar_id": calendar.id,
             }
         )
@@ -39,8 +31,8 @@ def setUpClass(cls):
                     "name": "Test 1",
                     "employee_id": cls.employee.id,
                     "holiday_status_id": leave_type.id,
-                    "date_from": datetime.today(),
-                    "date_to": (datetime.today() + relativedelta(days=1)),
+                    "request_date_from": datetime.today(),
+                    "request_date_to": (datetime.today() + relativedelta(days=1)),
                     "number_of_days": 1,
                     "state": "validate",
                 }
@@ -56,8 +48,8 @@ def setUpClass(cls):
                     "name": "Test 2",
                     "employee_id": cls.employee.id,
                     "holiday_status_id": leave_type.id,
-                    "date_from": (datetime.today() + relativedelta(days=3)),
-                    "date_to": (datetime.today() + relativedelta(days=5)),
+                    "request_date_from": (datetime.today() + relativedelta(days=3)),
+                    "request_date_to": (datetime.today() + relativedelta(days=5)),
                     "number_of_days": 2,
                     "state": "validate",
                 }

hr_holidays_summary_email/views/res_config_settings.xml

@@ -12,7 +12,7 @@
             ref="hr_holidays_settings.res_config_settings_view_form"
         />
         <field name="arch" type="xml">
-            <xpath expr="//div[@data-key='hr_holidays']/div" position="after">
+            <xpath expr="//app[@name='hr_holidays']/block" position="after">
                 <div class="row mt16 o_settings_container">
                     <div
                         class="col-12 o_setting_box"

hr_holidays_summary_email/views/res_users_views.xml

@@ -8,10 +8,7 @@
         <field name="inherit_id" ref="hr.res_users_view_form_profile" />
         <field name="arch" type="xml">
             <field name="email" position="after">
-                <field
-                    name="hr_leave_summary_type"
-                    attrs="{'readonly': [('can_edit', '=', False)]}"
-                />
+                <field name="hr_leave_summary_type" readonly="not can_edit" />
             </field>
         </field>
     </record>