Merge pull request #20 from altasoft/bugfix/InternalConverters

JsonConverters and  TypeConverters were generated as "public".

Author: temonk

Directory.Build.props

@@ -9,7 +9,7 @@
 	<Product>Domain Primitives</Product>
 	<Company>ALTA Software llc.</Company>
 	<Copyright>Copyright © 2024 ALTA Software llc.</Copyright>
-	<Version>5.1.2</Version>
+	<Version>5.1.3</Version>
   </PropertyGroup>
 
   <PropertyGroup>

src/AltaSoft.DomainPrimitives.Generator/Helpers/MethodGeneratorHelper.cs

@@ -131,24 +131,22 @@ void AddMapping(bool isNullable)
     /// <param name="context">The source production context.</param>
     internal static void ProcessTypeConverter(GeneratorData data, SourceProductionContext context)
     {
-        var accessibiliy = data.TypeSymbol.GetAccessibility();
-
         var friendlyName = data.UnderlyingType.ToString();
         var builder = new SourceCodeBuilder();
 
         builder.AppendSourceHeader("AltaSoft DomainPrimitives Generator");
 
-        builder.AppendUsings(new[] {
+        builder.AppendUsings([
             data.Namespace,
             "System",
             "System.ComponentModel",
             "System.Globalization",
             "AltaSoft.DomainPrimitives"
-        });
+        ]);
 
         builder.AppendNamespace(data.Namespace + ".Converters");
         builder.AppendSummary($"TypeConverter for <see cref = \"{data.ClassName}\"/>");
-        builder.AppendClass(false, accessibiliy + " sealed", data.ClassName + "TypeConverter", $"{friendlyName}Converter");
+        builder.AppendClass(false, "internal sealed", data.ClassName + "TypeConverter", $"{friendlyName}Converter");
         builder.AppendInheritDoc()
             .AppendLine("public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)")
             .OpenBracket();
@@ -281,8 +279,6 @@ internal static void ProcessEntityFrameworkValueConverter(GeneratorData data, So
     /// <param name="context">The source production context.</param>
     internal static void ProcessJsonConverter(GeneratorData data, SourceProductionContext context)
     {
-        var accessibiliy = data.TypeSymbol.GetAccessibility();
-
         var builder = new SourceCodeBuilder();
 
         builder.AppendSourceHeader("AltaSoft DomainPrimitives Generator");
@@ -305,7 +301,7 @@ internal static void ProcessJsonConverter(GeneratorData data, SourceProductionCo
 
         builder.AppendNamespace(data.Namespace + ".Converters");
         builder.AppendSummary($"JsonConverter for <see cref = \"{data.ClassName}\"/>");
-        builder.AppendClass(false, accessibiliy + " sealed", data.ClassName + "JsonConverter", $"JsonConverter<{data.ClassName}>");
+        builder.AppendClass(false, "internal sealed", data.ClassName + "JsonConverter", $"JsonConverter<{data.ClassName}>");
 
         builder.AppendInheritDoc()
             .Append("public override ").Append(data.ClassName).AppendLine(" Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)")

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.BoolValue_GeneratesAllInterfacesAndConverters#BoolValueJsonConverter.g.verified.cs

@@ -20,7 +20,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// JsonConverter for <see cref = "BoolValue"/>
 /// </summary>
-public sealed class BoolValueJsonConverter : JsonConverter<BoolValue>
+internal sealed class BoolValueJsonConverter : JsonConverter<BoolValue>
 {
     /// <inheritdoc/>
     public override BoolValue Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.BoolValue_GeneratesAllInterfacesAndConverters#BoolValueTypeConverter.g.verified.cs

@@ -18,7 +18,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// TypeConverter for <see cref = "BoolValue"/>
 /// </summary>
-public sealed class BoolValueTypeConverter : BooleanConverter
+internal sealed class BoolValueTypeConverter : BooleanConverter
 {
     /// <inheritdoc/>
     public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.ByteValue_GeneratesAllInterfacesAndConverters#ByteValueJsonConverter.g.verified.cs

@@ -20,7 +20,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// JsonConverter for <see cref = "ByteValue"/>
 /// </summary>
-public sealed class ByteValueJsonConverter : JsonConverter<ByteValue>
+internal sealed class ByteValueJsonConverter : JsonConverter<ByteValue>
 {
     /// <inheritdoc/>
     public override ByteValue Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.ByteValue_GeneratesAllInterfacesAndConverters#ByteValueTypeConverter.g.verified.cs

@@ -18,7 +18,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// TypeConverter for <see cref = "ByteValue"/>
 /// </summary>
-public sealed class ByteValueTypeConverter : ByteConverter
+internal sealed class ByteValueTypeConverter : ByteConverter
 {
     /// <inheritdoc/>
     public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.CharValue_GeneratesAllInterfacesAndConverters#CharValueJsonConverter.g.verified.cs

@@ -20,7 +20,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// JsonConverter for <see cref = "CharValue"/>
 /// </summary>
-public sealed class CharValueJsonConverter : JsonConverter<CharValue>
+internal sealed class CharValueJsonConverter : JsonConverter<CharValue>
 {
     /// <inheritdoc/>
     public override CharValue Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.CharValue_GeneratesAllInterfacesAndConverters#CharValueTypeConverter.g.verified.cs

@@ -18,7 +18,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// TypeConverter for <see cref = "CharValue"/>
 /// </summary>
-public sealed class CharValueTypeConverter : CharConverter
+internal sealed class CharValueTypeConverter : CharConverter
 {
     /// <inheritdoc/>
     public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.DateOnlyValue_GeneratesAllInterfacesAndConverters#DateOnlyValueJsonConverter.g.verified.cs

@@ -20,7 +20,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// JsonConverter for <see cref = "DateOnlyValue"/>
 /// </summary>
-public sealed class DateOnlyValueJsonConverter : JsonConverter<DateOnlyValue>
+internal sealed class DateOnlyValueJsonConverter : JsonConverter<DateOnlyValue>
 {
     /// <inheritdoc/>
     public override DateOnlyValue Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

tests/AltaSoft.DomainPrimitives.Generator.Tests/Snapshots/DomainPrimitiveGeneratorTest.DateOnlyValue_GeneratesAllInterfacesAndConverters#DateOnlyValueTypeConverter.g.verified.cs

@@ -18,7 +18,7 @@ namespace AltaSoft.DomainPrimitives.Converters;
 /// <summary>
 /// TypeConverter for <see cref = "DateOnlyValue"/>
 /// </summary>
-public sealed class DateOnlyValueTypeConverter : DateOnlyConverter
+internal sealed class DateOnlyValueTypeConverter : DateOnlyConverter
 {
     /// <inheritdoc/>
     public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)