v3.1.0

Author: GitRon

.ambient-package-update/metadata.py

@@ -7,6 +7,7 @@
 from ambient_package_update.metadata.maintainer import PackageMaintainer
 from ambient_package_update.metadata.package import PackageMetadata
 from ambient_package_update.metadata.readme import ReadmeContent
+from ambient_package_update.metadata.ruff_ignored_inspection import RuffIgnoredInspection
 
 METADATA = PackageMetadata(
     package_name="django_dynamic_admin_forms",
@@ -33,13 +34,18 @@
     supported_django_versions=SUPPORTED_DJANGO_VERSIONS,
     supported_python_versions=SUPPORTED_PYTHON_VERSIONS,
     dependencies=[
-        "django >=3.2",
+        f"Django>={SUPPORTED_DJANGO_VERSIONS[0]}",
     ],
     optional_dependencies={
         "dev": [
             *DEV_DEPENDENCIES,
             "unittest-parametrize~=1.4",
         ],
     },
-    ruff_ignore_list=[],
+    ruff_ignore_list=[
+        RuffIgnoredInspection(
+            key="RUF012", comment="Mutable class attributes should be annotated with `typing.ClassVar`"
+        ),
+        RuffIgnoredInspection(key="TRY003", comment="Avoid specifying long messages outside the exception class"),
+    ],
 )

.ambient-package-update/templates/snippets/content.tpl

@@ -16,8 +16,8 @@ Add simple interactions to the otherwise static django admin.
 - Add the module to `INSTALLED_APPS`:
     ```python
     INSTALLED_APPS = (
-        'django_dynamic_admin_forms',
-        'django.contrib.admin',
+        "django_dynamic_admin_forms",
+        "django.contrib.admin",
     )
     ```
     Ensure that the `dynamic_admin_forms` comes before the
@@ -28,8 +28,8 @@ Add simple interactions to the otherwise static django admin.
   ```python
   TEMPLATES = [
       {
-          'BACKEND': 'django.template.backends.django.DjangoTemplates',
-          'APP_DIRS': True,
+          "BACKEND": "django.template.backends.django.DjangoTemplates",
+          "APP_DIRS": True,
       },
   ]
   ```

.github/workflows/ci.yml

@@ -27,12 +27,10 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', ]
+        python-version: ['3.9', '3.10', '3.11', '3.12', ]
         django-version: ['42', '50', ]
 
         exclude:
-          - python-version: '3.8'
-            django-version: 50
           - python-version: '3.9'
             django-version: 50
 
@@ -73,7 +71,7 @@ jobs:
         with:
           name: coverage-data
 
-      - name: Combine coverage and fail if it's <100%
+      - name: Combine coverage and fail if it's <100.0%
         run: |
           python -m coverage html --skip-covered --skip-empty
           python -m coverage report --fail-under=100.0

.pre-commit-config.yaml

@@ -23,7 +23,7 @@ repos:
     rev: v3.16.0
     hooks:
       - id: pyupgrade
-        args: [ --py38-plus ]
+        args: [ --py39-plus ]
         stages: [ push ]
 
   - repo: https://github.com/adamchainz/django-upgrade

CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+**3.1.0**
+  * Dropped support for Python 3.8
+  * Added multiple ruff linters
+
 **3.0.4**
   * Linted docs with `blacken-docs` via `ambient-package-update`
 

django_dynamic_admin_forms/__init__.py

@@ -1,3 +1,3 @@
 """Add simple dynamic interaction to the otherwise static django admin."""
 
-__version__ = "3.0.4"
+__version__ = "3.1.0"

docs/conf.py

@@ -67,8 +67,6 @@
 
 # The theme to use for HTML and HTML Help pages.  See the documentation for
 # a list of builtin themes.
-#
-# html_theme = "alabaster"
 html_theme = "sphinx_rtd_theme"
 html_theme_options = {
     "display_version": False,

pyproject.toml

@@ -3,7 +3,7 @@ requires = ["flit_core>=3.4"]
 build-backend = "flit_core.buildapi"
 
 [project]
-name = "django-dynamic-admin-forms"
+name = "django_dynamic_admin_forms"
 authors = [
     {'name' = 'Ambient Digital', 'email' = '[email protected]'},
     {'name' = 'Fabian Binz', 'email' = '[email protected]'},
@@ -21,7 +21,6 @@ classifiers = [
     "Operating System :: OS Independent",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -31,7 +30,7 @@ classifiers = [
 dynamic = ["version", "description"]
 license = {"file" = "LICENSE.md"}
 dependencies = [
-    'django >=3.2',
+    'Django>=4.2',
 ]
 
 
@@ -42,14 +41,15 @@ dev = [
    'pytest-django~=4.7',
    'pytest-mock~=3.12',
    'coverage~=7.3',
-   'pre-commit~=3.5',
-   'ruff~=0.1.7',
+   'pre-commit~=3.7',
+   'ruff~=0.4',
    'sphinx~=7.1',
    'sphinx-rtd-theme~=2.0',
    'm2r2==0.3.3.post2',
    'mistune<2.0.0',
    'flit~=3.9',
-   'ambient-package-update~=24.6.4',
+   'keyring~=25.2',
+   'ambient-package-update~=24.7.3',
    'unittest-parametrize~=1.4',
 ]
 
@@ -75,18 +75,25 @@ lint.select = [
     "DTZ",     # flake8-datetimez
     "DJ",      # flake8-django
     "TD",      # flake8-to-do
-    "RUF100",  # Removes unnecessary "#noqa" comments
+    "RUF",     # Ruff-specific rules
     "YTT",     # Avoid non-future-prove usages of "sys"
-    # "FBT",     # Protects you from the "boolean trap bug"
     "C4",      # Checks for unnecessary conversions
     "PIE",     # Bunch of useful rules
-    # "SIM",     # Simplifies your code
     "INT",     # Validates your gettext translation strings
     "PERF",    # PerfLint
     "PGH",     # No all-purpose "# noqa" and eval validation
     "PL",      # PyLint
+    "LOG",     # flake8-logging
+    "TID",     # flake8-tidy-imports
+    "PLR2004", # Magic numbers
+    "BLE",     # Checks for except clauses that catch all exceptions
+    "ANN401",  # Checks that function arguments are annotated with a more specific type than Any
+    "TRY",     # Clean try/except
+    "ERA",     # Commented out code
 ]
 lint.ignore = [
+    'RUF012', # Mutable class attributes should be annotated with `typing.ClassVar`
+    'TRY003', # Avoid specifying long messages outside the exception class
 ]
 
 # Allow autofix for all enabled rules (when `--fix`) is provided.
@@ -101,16 +108,21 @@ lint.fixable = [
     "DTZ",     # flake8-datetimez
     "DJ",      # flake8-django
     "TD",      # flake8-to-do
-    "RUF100",  # Removes unnecessary "#noqa" comments
+    "RUF",     # Ruff-specific rules
     "YTT",     # Avoid non-future-prove usages of "sys"
-    # "FBT",     # Protects you from the "boolean trap bug"
     "C4",      # Checks for unnecessary conversions
     "PIE",     # Bunch of useful rules
-    # "SIM",     # Simplifies your code
     "INT",     # Validates your gettext translation strings
     "PERF",    # PerfLint
     "PGH",     # No all-purpose "# noqa" and eval validation
     "PL",      # PyLint
+    "LOG",     # flake8-logging
+    "TID",     # flake8-tidy-imports
+    "PLR2004", # Magic numbers
+    "BLE",     # Checks for except clauses that catch all exceptions
+    "ANN401",  # Checks that function arguments are annotated with a more specific type than Any
+    "TRY",     # Clean try/except
+    "ERA",     # Commented out code
 ]
 lint.unfixable = []
 
@@ -142,7 +154,7 @@ exclude = [
 line-length = 120
 
 # Allow unused variables when underscore-prefixed.
-dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
+lint.dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
 
 # Assume Python 3.12
 target-version = "py312"
@@ -162,10 +174,6 @@ line-ending = "auto"
 
 [tool.tox]
 legacy_tox_ini = """
-[tox]
-envlist = py{38,39,310,311}-django{32,41,42}
-isolated_build = True
-
 [testenv]
 # Django deprecation overview: https://www.djangoproject.com/download/
 deps =
@@ -177,7 +185,6 @@ commands =
 
 [gh-actions]
 python =
-    3.8: py38
     3.9: py39
     3.10: py310
     3.11: py311

tests/test_admin_unit.py

@@ -21,8 +21,6 @@ class TestDynamicModelAdminMixin(TestCase):
     @classmethod
     def setUpTestData(cls):
         pass
-        # cls.mixin = DynamicModelAdminMixin()
-        # cls.mixin.opts = site._registry[User]
 
     def get_request(self, is_superuser: bool):
         factory = RequestFactory()