Fix csharpsquid:S2223 issues, #679

Author: paulirwin

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData1.cs

@@ -48,8 +48,10 @@ internal class KStemData1
         private KStemData1()
         {
         }
+
+        // LUCENENET specific - made readonly
         // KStemData1 ... KStemData8 are created from "head_word_list.txt"
-        internal static string[] data = new string[] {
+        internal static readonly string[] data = {
             "aback","abacus","abandon","abandoned","abase",
             "abash","abate","abattoir","abbess","abbey",
             "abbot","abbreviate","abbreviation","abc","abdicate",
@@ -752,4 +754,4 @@ private KStemData1()
             "cascara","case","casebook","casein","casework",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData2.cs

@@ -47,7 +47,9 @@ internal class KStemData2
         private KStemData2()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "cash","cashew","cashier","cashmere","casing",
             "casino","cask","casket","casque","cassava",
             "casserole","cassette","cassock","cassowary","cast",
@@ -750,4 +752,4 @@ private KStemData2()
             "distal","distance","distant","distantly","distaste",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData3.cs

@@ -47,7 +47,9 @@ internal class KStemData3
         private KStemData3()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "distasteful","distemper","distempered","distend","distension",
             "distil","distill","distillation","distiller","distillery",
             "distinct","distinction","distinctive","distinguish","distinguishable",
@@ -750,4 +752,4 @@ private KStemData3()
             "grange","granite","grannie","granny","grant",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData4.cs

@@ -47,7 +47,9 @@ internal class KStemData4
         private KStemData4()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "granular","granulate","granule","grape","grapefruit",
             "grapeshot","grapevine","graph","graphic","graphical",
             "graphically","graphite","graphology","grapnel","grapple",
@@ -750,4 +752,4 @@ private KStemData4()
             "locate","located","location","loch","loci",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData5.cs

@@ -47,7 +47,9 @@ internal class KStemData5
         private KStemData5()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "lock","locker","locket","lockjaw","locknut",
             "lockout","locks","locksmith","lockstitch","lockup",
             "loco","locomotion","locomotive","locum","locus",
@@ -750,4 +752,4 @@ private KStemData5()
             "peculiarly","pecuniary","pedagogue","pedagogy","pedal",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData6.cs

@@ -47,7 +47,9 @@ internal class KStemData6
         private KStemData6()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "pedant","pedantic","pedantry","peddle","peddler",
             "pederast","pederasty","pedestal","pedestrian","pediatrician",
             "pediatrics","pedicab","pedicel","pedicure","pedigree",
@@ -750,4 +752,4 @@ private KStemData6()
             "running","runny","runs","runt","runway",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData7.cs

@@ -47,7 +47,9 @@ internal class KStemData7
         private KStemData7()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "rupee","rupture","rural","ruritanian","ruse",
             "rush","rushes","rushlight","rusk","russet",
             "rust","rustic","rusticate","rustication","rustle",
@@ -750,4 +752,4 @@ private KStemData7()
             "tenement","tenet","tenner","tennis","tenon",
         };
     }
-}
+}

src/Lucene.Net.Analysis.Common/Analysis/En/KStemData8.cs

@@ -47,7 +47,9 @@ internal class KStemData8
         private KStemData8()
         {
         }
-        internal static string[] data = new string[] {
+
+        // LUCENENET specific - made readonly
+        internal static readonly string[] data = {
             "tenor","tenpin","tense","tensile","tension",
             "tent","tentacle","tentative","tenterhooks","tenuity",
             "tenuous","tenure","tepee","tepid","tequila",
@@ -649,4 +651,4 @@ private KStemData8()
             "zoom","zoophyte","zouave","zucchini","zulu",
         };
     }
-}
+}

src/Lucene.Net.Analysis.OpenNLP/OpenNLPTokenizer.cs

@@ -32,7 +32,8 @@ namespace Lucene.Net.Analysis.OpenNlp
     /// </summary>
     public sealed class OpenNLPTokenizer : SegmentingTokenizerBase
     {
-        public static int EOS_FLAG_BIT = 1;
+        // LUCENENET specific - made const, since it is never modified. Removed in Lucene 9.5.0.
+        public const int EOS_FLAG_BIT = 1;
 
         private readonly ICharTermAttribute termAtt;
         private readonly IFlagsAttribute flagsAtt;

src/Lucene.Net.Analysis.SmartCn/AnalyzerProfile.cs

@@ -34,7 +34,7 @@ namespace Lucene.Net.Analysis.Cn.Smart
     /// To place the files in an alternate location, set an environment variable named "smartcn.data.dir"
     /// with the name of the directory the "bigramdict.dct" and "coredict.dct" files can be located within.
     /// <para/>
-    /// The default "bigramdict.dct" and "coredict.dct" files can be found at: 
+    /// The default "bigramdict.dct" and "coredict.dct" files can be found at:
     /// <a href="https://issues.apache.org/jira/browse/LUCENE-1629">https://issues.apache.org/jira/browse/LUCENE-1629</a>.
     /// <para/>
     /// @lucene.experimental
@@ -44,14 +44,15 @@ public static class AnalyzerProfile // LUCENENET specific: CA1052 Static holder
         /// <summary>
         /// Global indicating the configured analysis data directory
         /// </summary>
-        public static string ANALYSIS_DATA_DIR = "";
+        // LUCENENET specific - changed from a mutable static field to a property.
+        public static string ANALYSIS_DATA_DIR { get; set; } = "";
 
         static AnalyzerProfile()
         {
             Init();
         }
 
-        // LUCENENET specific - changed the logic here to leave the 
+        // LUCENENET specific - changed the logic here to leave the
         // ANALYSIS_DATA_DIR an empty string if it is not found. This
         // allows us to skip loading files from disk if there are no files
         // to load (and fixes LUCENE-1817 that prevents the on-disk files
@@ -79,7 +80,6 @@ private static void Init()
                 ANALYSIS_DATA_DIR = candidatePath;
                 return;
             }
-            
 
             try
             {