refactor: Use the same http client across project

Signed-off-by: Xuanwo <[email protected]>

Author: Xuanwo

src/io_util/http_client.rs

@@ -0,0 +1,40 @@
+// Copyright 2022 Datafuse Labs.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::ops::Deref;
+
+/// HttpClient that used across opendal.
+///
+/// NOTE: we could change or support more underlying http backend.
+#[derive(Debug, Clone)]
+pub struct HttpClient(
+    hyper::Client<hyper_tls::HttpsConnector<hyper::client::HttpConnector>, hyper::Body>,
+);
+
+impl HttpClient {
+    /// Create a new http client.
+    pub fn new() -> Self {
+        HttpClient(hyper::Client::builder().build(hyper_tls::HttpsConnector::new()))
+    }
+}
+
+/// Forward all function to http backend.
+impl Deref for HttpClient {
+    type Target =
+        hyper::Client<hyper_tls::HttpsConnector<hyper::client::HttpConnector>, hyper::Body>;
+
+    fn deref(&self) -> &Self::Target {
+        &self.0
+    }
+}

src/io_util/mod.rs

@@ -40,6 +40,9 @@ mod http_body;
 pub(crate) use http_body::new_http_channel;
 pub(crate) use http_body::HttpBodyWriter;
 
+mod http_client;
+pub(crate) use http_client::HttpClient;
+
 mod seekable_reader;
 pub use seekable_reader::seekable_read;
 pub use seekable_reader::SeekableReader;

src/services/azblob/backend.rs

@@ -47,8 +47,8 @@ use crate::accessor::AccessorMetadata;
 use crate::error::other;
 use crate::error::BackendError;
 use crate::error::ObjectError;
-use crate::io_util::new_http_channel;
 use crate::io_util::HttpBodyWriter;
+use crate::io_util::{new_http_channel, HttpClient};
 use crate::object::ObjectMetadata;
 use crate::ops::BytesRange;
 use crate::ops::OpCreate;
@@ -202,7 +202,7 @@ impl Builder {
             ("endpoint".to_string(), endpoint.to_string()),
         ]);
 
-        let client = hyper::Client::builder().build(hyper_tls::HttpsConnector::new());
+        let client = HttpClient::new();
 
         let mut signer_builder = Signer::builder();
         if let (Some(name), Some(key)) = (&self.account_name, &self.account_key) {
@@ -228,7 +228,7 @@ impl Builder {
 #[derive(Debug, Clone)]
 pub struct Backend {
     container: String,
-    client: hyper::Client<hyper_tls::HttpsConnector<hyper::client::HttpConnector>, hyper::Body>,
+    client: HttpClient,
     root: String, // root will be "/" or /abc/
     endpoint: String,
     signer: Arc<Signer>,

src/services/s3/backend.rs

@@ -48,8 +48,8 @@ use super::object_stream::DirStream;
 use crate::error::other;
 use crate::error::BackendError;
 use crate::error::ObjectError;
-use crate::io_util::new_http_channel;
 use crate::io_util::HttpBodyWriter;
+use crate::io_util::{new_http_channel, HttpClient};
 use crate::ops::BytesRange;
 use crate::ops::OpCreate;
 use crate::ops::OpDelete;
@@ -415,10 +415,7 @@ impl Builder {
     // Read RFC-0057: Auto Region for detailed behavior.
     async fn detect_region(
         &self,
-        client: &hyper::Client<
-            hyper_tls::HttpsConnector<hyper::client::HttpConnector>,
-            hyper::Body,
-        >,
+        client: &HttpClient,
         bucket: &str,
         context: &HashMap<String, String>,
     ) -> Result<(String, String)> {
@@ -628,7 +625,7 @@ impl Builder {
                 })?),
             };
 
-        let client = hyper::Client::builder().build(hyper_tls::HttpsConnector::new());
+        let client = HttpClient::new();
 
         let (endpoint, region) = self.detect_region(&client, bucket, &context).await?;
         context.insert("endpoint".to_string(), endpoint.clone());
@@ -680,7 +677,7 @@ pub struct Backend {
     bucket: String,
     endpoint: String,
     signer: Arc<Signer>,
-    client: hyper::Client<hyper_tls::HttpsConnector<hyper::client::HttpConnector>, hyper::Body>,
+    client: HttpClient,
     // root will be "/" or "/abc/"
     root: String,
 
@@ -1295,7 +1292,7 @@ mod tests {
 
     #[tokio::test]
     async fn test_detect_region() {
-        let client = hyper::Client::builder().build(hyper_tls::HttpsConnector::new());
+        let client = HttpClient::new();
 
         let endpoint_cases = vec![
             Some("s3.amazonaws.com"),