chore: set defaults in testmain (#706)

* chore: set defaults in testmain

This keeps the default configuration in one place, and at the same time
allows for acceptance tests to not to have to use the make targets to
get the default values set (useful in e.g the IDE).

This also flips `USE_TESTCONTAINERS` to have a default of `true` (for now
we don't do that in CI). This is something which can be discussed to see
if that is desired by others.

Signed-off-by: Blake Pettersson <[email protected]>

* refactor: some minor tweaks

* add new line when printing
* inline `runTestSuite` logic

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>

Author: blakepettersson

.github/workflows/tests.yml

@@ -99,6 +99,7 @@ jobs:
       - name: Run acceptance tests
         env:
           ARGOCD_VERSION: ${{ matrix.argocd_version }}
+          USE_TESTCONTAINERS: false
         run: make testacc
 
   # This job aggregates test results. It's the required check for branch protection.

GNUmakefile

@@ -1,11 +1,6 @@
 default: build
 
-ARGOCD_INSECURE?=true
-ARGOCD_SERVER?=127.0.0.1:8080
-ARGOCD_AUTH_USERNAME?=admin
-ARGOCD_AUTH_PASSWORD?=acceptancetesting
-ARGOCD_VERSION?=v3.0.0
-K3S_VERSION?=v1.31.6-k3s1
+# To see which other env vars are set, please refer to internal/testhelpers/suite.go
 TEST_FILTER?=
 
 export
@@ -32,9 +27,6 @@ test:
 testacc:
 	TF_ACC=1 go test -v -cover -timeout 20m -run="$(TEST_FILTER)" ./...
 
-testacc_testcontainers:
-	TF_ACC=1 USE_TESTCONTAINERS=true go test -v -cover -timeout 30m -run="$(TEST_FILTER)" ./...
-
 testacc_clean_env:
 	kind delete cluster --name argocd
 

internal/testhelpers/suite.go

@@ -2,6 +2,7 @@ package testhelpers
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"sync"
 	"testing"
@@ -15,24 +16,33 @@ var (
 
 // TestMain is a helper function to be used in test files' TestMain functions
 func TestMain(m *testing.M) {
+	envDefaultValue("ARGOCD_AUTH_USERNAME", "admin")
+	envDefaultValue("ARGOCD_AUTH_PASSWORD", "acceptancetesting")
+	envDefaultValue("ARGOCD_SERVER", "127.0.0.1:8080")
+	envDefaultValue("ARGOCD_INSECURE", "true")
+	envDefaultValue("USE_TESTCONTAINERS", "true")
+	envDefaultValue("K3S_VERSION", "v1.31.6-k3s1")
+	envDefaultValue("ARGOCD_VERSION", "v3.0.0")
+
 	if os.Getenv("USE_TESTCONTAINERS") == "true" {
-		SetupTestSuite(m)
+		os.Exit(runTestSuite(m))
 	} else {
 		os.Exit(m.Run())
 	}
 }
 
+func envDefaultValue(envvar, defaultValue string) {
+	if v := os.Getenv(envvar); v == "" {
+		fmt.Printf("environment variable %s not set; using %s as default value\n", envvar, defaultValue)
+		_ = os.Setenv(envvar, defaultValue)
+	}
+}
+
 const (
 	// DefaultTestTimeout is the default timeout for test setup
 	DefaultTestTimeout = 15 * time.Minute
 )
 
-// SetupTestSuite sets up a shared test environment for all acceptance tests
-func SetupTestSuite(m *testing.M) {
-	code := runTestSuite(m)
-	os.Exit(code)
-}
-
 func runTestSuite(m *testing.M) int {
 	ctx, cancel := context.WithTimeout(context.Background(), DefaultTestTimeout)
 	defer cancel()