refactor: some minor tweaks

* add new line when printing
* inline `runTestSuite` logic

Signed-off-by: Blake Pettersson <[email protected]>

Author: blakepettersson

internal/testhelpers/suite.go

@@ -25,15 +25,15 @@ func TestMain(m *testing.M) {
 	envDefaultValue("ARGOCD_VERSION", "v3.0.0")
 
 	if os.Getenv("USE_TESTCONTAINERS") == "true" {
-		SetupTestSuite(m)
+		os.Exit(runTestSuite(m))
 	} else {
 		os.Exit(m.Run())
 	}
 }
 
 func envDefaultValue(envvar, defaultValue string) {
 	if v := os.Getenv(envvar); v == "" {
-		fmt.Printf("%s not set; using %s as default value", envvar, defaultValue)
+		fmt.Printf("environment variable %s not set; using %s as default value\n", envvar, defaultValue)
 		_ = os.Setenv(envvar, defaultValue)
 	}
 }
@@ -43,12 +43,6 @@ const (
 	DefaultTestTimeout = 15 * time.Minute
 )
 
-// SetupTestSuite sets up a shared test environment for all acceptance tests
-func SetupTestSuite(m *testing.M) {
-	code := runTestSuite(m)
-	os.Exit(code)
-}
-
 func runTestSuite(m *testing.M) int {
 	ctx, cancel := context.WithTimeout(context.Background(), DefaultTestTimeout)
 	defer cancel()