return correct response - e2e exisiting test fix

Signed-off-by: nidhi-singh02 <[email protected]>

Author: nidhi-singh02

node-api/handlers/node/sync.go

@@ -33,7 +33,7 @@ var (
 )
 
 // Syncing returns the syncing status of the node.
-func (h *Handler) Syncing(handlers.Context) (any, error) {
+func (h *Handler) Syncing(_ handlers.Context) (any, error) {
 	node := h.backend.GetNode()
 	if node == nil {
 		return nil, errNilNode
@@ -62,5 +62,6 @@ func (h *Handler) Syncing(handlers.Context) (any, error) {
 		response.IsSyncing = true
 	}
 
-	return nodetypes.NewResponse(&response), nil
+	return response, nil
+
 }

node-api/handlers/node/types/response.go

@@ -27,20 +27,3 @@ type SyncingData struct {
 	IsOptimistic bool  `json:"is_optimistic"`
 	ELOffline    bool  `json:"el_offline"`
 }
-
-type GenericResponse struct {
-	ExecutionOptimistic bool `json:"execution_optimistic"`
-	Finalized           bool `json:"finalized"`
-	Data                any  `json:"data"`
-}
-
-// NewResponse creates a new response with CometBFT's finality guarantees.
-func NewResponse(data any) GenericResponse {
-	return GenericResponse{
-		// All data is finalized in CometBFT since we only return data for slots up to head
-		Finalized: true,
-		// Never optimistic since we only return finalized data
-		ExecutionOptimistic: false,
-		Data:                data,
-	}
-}