Skip to content

Commit 3e5b098

Browse files
authored
Improve npm detection (#220)
Co-authored-by: Matan Shati <>
1 parent 2f371f9 commit 3e5b098

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

detect_secrets/plugins/npm.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,8 @@ class NpmDetector(RegexBasedDetector):
1313
denylist = [
1414
# npmrc authToken
1515
# ref. https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc
16-
re.compile(r'\/\/.+\/:_authToken=\s*((npm_.+)|([A-Fa-f0-9-]{36})).*'),
16+
re.compile(
17+
r'(?:npm_[A-Za-z0-9-]{36})|' +
18+
r'(?:(?:_authToken|NPM[ _-]?TOKEN)[\s\S]{0,5}?(?:NpmToken\.)?([a-z0-9-]{36}).*)',
19+
),
1720
]

tests/plugins/npm_test.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@ class TestNpmDetector:
1111
('//registry.npmjs.org/:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', True),
1212
('//registry.npmjs.org/:_authToken=346a14f2-a672-4668-a892-956a462ab56e', True),
1313
('//registry.npmjs.org/:_authToken= 743b294a-cd03-11ec-9d64-0242ac120002', True),
14-
('//registry.npmjs.org/:_authToken=npm_xxxxxxxxxxx', True),
15-
('//registry.npmjs.org:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', False),
16-
('registry.npmjs.org/:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', False),
17-
('///:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', False),
18-
('_authToken=743b294a-cd03-11ec-9d64-0242ac120002', False),
14+
('//registry.npmjs.org/:_authToken=npm_xxxxxxxxxxx', False),
15+
('//registry.npmjs.org:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', True),
16+
('registry.npmjs.org/:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', True),
17+
('///:_authToken=743b294a-cd03-11ec-9d64-0242ac120002', True),
18+
('_authToken=743b294a-cd03-11ec-9d64-0242ac120002', True),
19+
('"_authToken" = "743b294a-cd03-11ec-9d64-0242ac120002"', True),
1920
('foo', False),
2021
('//registry.npmjs.org/:_authToken=${NPM_TOKEN}', False),
2122
],

0 commit comments

Comments
 (0)