ci: bump golangci-lint to v1.50.1

The `varcheck` linter has been removed as it is unmaintained.  Also bump
the golangci-lint action to v3.3.1. Use the new `skip-cache` directive
to disable caching instead of the more specific options.  Remove
`only-new-issues: false` given that `false` is the default value.
Finally, remove `skip-go-installation` as this is an unknown config
option to the linter which gives a warning.

Signed-off-by: Robin Hahling <[email protected]>

Author: rolinh

.github/workflows/static-checks.yaml

@@ -18,14 +18,11 @@ jobs:
         with:
           go-version: '1.18.3'
       - name: Run static checks
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376
         with:
-          version: v1.47.0
+          version: v1.50.1
           args: --config=.golangci.yml --verbose
-          only-new-issues: false
-          skip-go-installation: true
-          skip-pkg-cache: true
-          skip-build-cache: true
+          skip-cache: true
       - name: Check gofmt formatting
         run: |
           go fmt ./...

.golangci.yml

@@ -17,7 +17,6 @@ linters:
     - revive
     - staticcheck
     - unused
-    - varcheck
 
 issues:
   exclude-rules:

api/v1/tetragon/codegen/eventchecker/eventchecker.pb.go

@@ -10,8 +10,9 @@ import (
 // with net.Listen.
 //
 // addresses can be:
-//  unix://absolute_path for unix sockets
-//  <host>:<port> for TCP (more specifically, an address that can be passed to net.Listen)
+//
+//	unix://absolute_path for unix sockets
+//	<host>:<port> for TCP (more specifically, an address that can be passed to net.Listen)
 //
 // Note that the client (tetra) uses https://github.com/grpc/grpc-go/blob/v1.51.0/clientconn.go#L135
 // With the syntax is documented in https://github.com/grpc/grpc/blob/master/doc/naming.md. The

cmd/tetragon/addr.go

@@ -12,9 +12,9 @@ import (
 // ListenWithRename creates a "unix" listener for the given path and the given mode
 //
 // Go's net.Listen() performs three system calls at once:
-//  - socket, where the file descriptor is created
-//  - bind, where the unix socket file is created
-//  - listen, where the socket can now accept connections
+//   - socket, where the file descriptor is created
+//   - bind, where the unix socket file is created
+//   - listen, where the socket can now accept connections
 //
 // Hence, doing a chmod(2) after Listen is racy because a client can connect
 // between the listen(2) and the chmod(2) calls. One solution would be to use