This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Change the extension of generated files to .gen.tsx (TS) and .gen.js (Flow/Untyped).#90
Merged
Merged
Conversation
Test a breaking change to the extension of generated files. Change the extension of generated fies to make it uniform across TypeScript and Flow, and independent from webpack plugins. No need for a special webpack plugin to read `.re.js` files instead of `.re` files. No difference in instructions to specify the current file in `bs.value` with TypeScript of Flow/Untyped.
jchavarri
reviewed
Nov 7, 2018
| { | ||
| loader: "extension-replace-loader", | ||
| query: { | ||
| exts: [{ from: ".re", to: ".re.js" }] |
Contributor
There was a problem hiding this comment.
Is removing this loader possible because the new .regen extension has more than 2 characters? I was thinking .gt would be smaller and more representative of genType, just curious if there is any technical reason for picking the 5 chars name :)
Collaborator
Author
There was a problem hiding this comment.
No special reason, the name of the extension is open. The only problem was "re.js" without ".js" becoming ".re" and confusing webpack.
cristianoc
changed the title
.gen.tsx (TS) and .gen.js (Flow/Untyped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test a breaking change to the extension of generated files.
Change the extension of generated fies to make it uniform across TypeScript and Flow, and independent from webpack plugins.
No need for a special webpack plugin to read
.re.jsfiles instead of.refiles.No difference in instructions to specify the current file in
bs.valuewith TypeScript of Flow/Untyped.