This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Use import instead of require in ES modules, excep when values are im…#92
Merged
Conversation
…ported. Imported values lead to cyclic imports between the generated file and the `.bs.js` file. So in case of imported values, requires are emitted. In other cases, for ES6, imports are equipped. TypeScript still needs lookint into. Two outstanding issues is e.g. ReasonReact.js is not found. Another issue is that .bs.js files are do not default to “any” anymore, and type errors are given.
Using import’s for TypeScript with ES6 for untyped modules complicates things. Skipping for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ported.
Imported values lead to cyclic imports between the generated file and the
.bs.jsfile. So in case of imported JS values in Reason, requires are emitted. In other cases, for ES6, imports are emitted.TypeScript still needs looking into. Two outstanding issues are: 1) ReasonReact.js is not found anymore. 2) .bs.js files do not default to “any” anymore, and type errors are given.