Skip to content

Commit 1c9af43

Browse files
Jules-Bertholettaiki-e
authored andcommitted
Don't allow(dropping_copy_types)
1 parent e784567 commit 1c9af43

File tree

5 files changed

+13
-22
lines changed

5 files changed

+13
-22
lines changed

crossbeam-channel/tests/mpsc.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,7 @@
2020
//! - https://github.com/rust-lang/rust/blob/master/COPYRIGHT
2121
//! - https://www.rust-lang.org/en-US/legal.html
2222
23-
#![allow(
24-
dropping_copy_types,
25-
clippy::match_single_binding,
26-
clippy::redundant_clone
27-
)]
23+
#![allow(clippy::match_single_binding, clippy::redundant_clone)]
2824

2925
use std::sync::mpsc::{RecvError, RecvTimeoutError, TryRecvError};
3026
use std::sync::mpsc::{SendError, TrySendError};

crossbeam-channel/tests/ready.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
//! Tests for channel readiness using the `Select` struct.
22
3-
#![allow(dropping_copy_types)]
4-
53
use std::any::Any;
64
use std::cell::Cell;
75
use std::thread;

crossbeam-channel/tests/select.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
//! Tests for channel selection using the `Select` struct.
22
3-
#![allow(dropping_copy_types)]
4-
53
use std::any::Any;
64
use std::cell::Cell;
75
use std::thread;

crossbeam-channel/tests/select_macro.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//! Tests for the `select!` macro.
22
33
#![forbid(unsafe_code)] // select! is safe.
4-
#![allow(dropping_copy_types, clippy::match_single_binding)]
4+
#![allow(clippy::match_single_binding)]
55

66
use std::any::Any;
77
use std::cell::Cell;
@@ -1212,32 +1212,32 @@ fn result_types() {
12121212
let (_, r) = bounded::<i32>(0);
12131213

12141214
select! {
1215-
recv(r) -> res => drop::<Result<i32, RecvError>>(res),
1215+
recv(r) -> res => { let _: Result<i32, RecvError> = res; },
12161216
}
12171217
select! {
1218-
recv(r) -> res => drop::<Result<i32, RecvError>>(res),
1218+
recv(r) -> res => { let _: Result<i32, RecvError> = res; },
12191219
default => {}
12201220
}
12211221
select! {
1222-
recv(r) -> res => drop::<Result<i32, RecvError>>(res),
1222+
recv(r) -> res => { let _: Result<i32, RecvError> = res; },
12231223
default(ms(0)) => {}
12241224
}
12251225

12261226
select! {
1227-
send(s, 0) -> res => drop::<Result<(), SendError<i32>>>(res),
1227+
send(s, 0) -> res => { let _: Result<(), SendError<i32>> = res; },
12281228
}
12291229
select! {
1230-
send(s, 0) -> res => drop::<Result<(), SendError<i32>>>(res),
1230+
send(s, 0) -> res => { let _: Result<(), SendError<i32>> = res; },
12311231
default => {}
12321232
}
12331233
select! {
1234-
send(s, 0) -> res => drop::<Result<(), SendError<i32>>>(res),
1234+
send(s, 0) -> res => { let _: Result<(), SendError<i32>> = res; },
12351235
default(ms(0)) => {}
12361236
}
12371237

12381238
select! {
1239-
send(s, 0) -> res => drop::<Result<(), SendError<i32>>>(res),
1240-
recv(r) -> res => drop::<Result<i32, RecvError>>(res),
1239+
send(s, 0) -> res => { let _: Result<(), SendError<i32>> = res; },
1240+
recv(r) -> res => { let _: Result<i32, RecvError> = res; },
12411241
}
12421242
}
12431243

crossbeam-epoch/src/deferred.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,17 @@ impl Deferred {
8989

9090
#[cfg(all(test, not(crossbeam_loom)))]
9191
mod tests {
92-
#![allow(dropping_copy_types)]
93-
9492
use super::Deferred;
9593
use std::cell::Cell;
94+
use std::convert::identity;
9695

9796
#[test]
9897
fn on_stack() {
9998
let fired = &Cell::new(false);
10099
let a = [0usize; 1];
101100

102101
let d = Deferred::new(move || {
103-
drop(a);
102+
let _ = identity(a);
104103
fired.set(true);
105104
});
106105

@@ -115,7 +114,7 @@ mod tests {
115114
let a = [0usize; 10];
116115

117116
let d = Deferred::new(move || {
118-
drop(a);
117+
let _ = identity(a);
119118
fired.set(true);
120119
});
121120

0 commit comments

Comments
 (0)