Skip to content

Commit 5ff1178

Browse files
dguidoclaude
andcommitted
fix: correct Windows version boundary test migration error
- Fix test to use 0.4.5 as Windows minimum (not 0.4.11) - Test 0.3.9 as 'too low' version (not 0.4.10) - Matches original bash test expectations exactly - Windows binaries DO exist for 0.4.10, so previous test was incorrect 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent c4a9d7a commit 5ff1178

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/test_platform_specific.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,10 @@ def test_windows_version_boundaries(self, run_command, backup_current_version):
111111
# Install all versions (as original script does)
112112
run_command("solc-select install all", check=False)
113113

114-
# Test minimum version (0.4.11 on Windows)
115-
result = run_command("solc-select use 0.4.11", check=False)
114+
# Test minimum version (0.4.5 on Windows, matching original bash test)
115+
result = run_command("solc-select use 0.4.5", check=False)
116116
assert result.returncode == 0
117-
assert "Switched global version to 0.4.11" in result.stdout, (
117+
assert "Switched global version to 0.4.5" in result.stdout, (
118118
f"Failed to set minimum version. Output: {result.stdout}"
119119
)
120120

@@ -131,11 +131,11 @@ def test_windows_version_boundaries(self, run_command, backup_current_version):
131131
f"Failed to set maximum version. Output: {result.stdout}"
132132
)
133133

134-
# Test version too low
135-
result = run_command("solc-select use 0.4.10", check=False)
134+
# Test version too low (matching original bash test: 0.3.9)
135+
result = run_command("solc-select use 0.3.9", check=False)
136136
assert result.returncode != 0
137137
assert (
138-
"Invalid version - only solc versions above '0.4.11' are available" in result.stdout
138+
"Invalid version - only solc versions above '0.4.5' are available" in result.stdout
139139
), f"Did not fail for version too low. Output: {result.stdout}"
140140

141141
# Test version too high

0 commit comments

Comments
 (0)