Merge pull request #51 from dgomie/debugging-v1beta

dgomie · web-flow · commit 392925df0d43 · 2025-05-06T13:12:38.000-04:00
modify update standings logic to include vote counts of 0
diff --git a/src/firebaseAdmin.js b/src/firebaseAdmin.js
@@ -49,7 +49,7 @@ export const adminUpdateLegionStandings = async (legionId) => {
         round.submissions.forEach((submission) => {
           const { uid, voteCount } = submission;
 
-          if (uid && voteCount) {
+          if (uid !== undefined && typeof voteCount === 'number') {
             userVotes[uid] = (userVotes[uid] || 0) + voteCount;
           }
         });

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export const adminUpdateLegionStandings = async (legionId) => {`
`49`	`49`	`round.submissions.forEach((submission) => {`
`50`	`50`	`const { uid, voteCount } = submission;`
`51`	`51`
`52`		`- if (uid && voteCount) {`
	`52`	`+ if (uid !== undefined && typeof voteCount === 'number') {`
`53`	`53`	`userVotes[uid] = (userVotes[uid] \|\| 0) + voteCount;`
`54`	`54`	`}`
`55`	`55`	`});`