Make filesystem sync operation fatal on failure

jackowfish · imeoer · commit 14c0062ceeaa · 2025-07-11T10:42:45.000+08:00
Signed-off-by: Jack Decker &lt;jack@thundercompute.com&gt;
diff --git a/contrib/nydusify/pkg/committer/commiter.go b/contrib/nydusify/pkg/committer/commiter.go
@@ -235,7 +235,7 @@ func (cm *Committer) Commit(ctx context.Context, opt Opt) error {
 	// and not yet visible in the overlay filesystem's upper directory
 	logrus.Infof("syncing filesystem before commit")
 	if err := cm.syncFilesystem(ctx, opt.ContainerID); err != nil {
-		logrus.Warnf("failed to sync filesystem, continuing anyway: %v", err)
+		return errors.Wrap(err, "failed to sync filesystem")
 	}
 
 	if err := cm.pause(ctx, opt.ContainerID, commit); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ func (cm *Committer) Commit(ctx context.Context, opt Opt) error {`
`235`	`235`	`// and not yet visible in the overlay filesystem's upper directory`
`236`	`236`	`logrus.Infof("syncing filesystem before commit")`
`237`	`237`	`if err := cm.syncFilesystem(ctx, opt.ContainerID); err != nil {`
`238`		`- logrus.Warnf("failed to sync filesystem, continuing anyway: %v", err)`
	`238`	`+ return errors.Wrap(err, "failed to sync filesystem")`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`if err := cm.pause(ctx, opt.ContainerID, commit); err != nil {`