Skip to content

Commit 9f3dd3f

Browse files
authored
Merge pull request #21922 from hangshao0/Test
Add missing exit trace point in objectMonitorExit
2 parents f438da4 + 103b53d commit 9f3dd3f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

runtime/vm/j9vm.tdf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ TraceExit=Trc_VM_flushForClassesUnload_Exit group=profilingbc Overhead=1 Level=1
154154

155155
TraceEntry=Trc_VM_objectMonitorExit_Entry Overhead=1 Level=4 Template="objectMonitorExit (obj=%p)"
156156
TraceEvent=Trc_VM_objectMonitorExit_SmartDecisionPoint Overhead=1 Level=4 Template="pro=%d,anti=%d"
157-
TraceExit=Trc_VM_objectMonitorExit_Exit Overhead=1 Level=4 Template="objectMonitorExit"
157+
TraceExit=Trc_VM_objectMonitorExit_Exit Obsolete Overhead=1 Level=4 Template="objectMonitorExit"
158158
TraceExit=Trc_VM_objectMonitorExit_Exit_FCBSet Overhead=1 Level=4 Template="objectMonitorExit (FCB is set)"
159159
TraceExit-Exception=Trc_VM_objectMonitorExit_Exit_IllegalInflatedLock Overhead=1 Level=4 Template="objectMonitorExit (IllegalMonitorState in objectMonitorExit. Inflated monitor's owner is %p, not %p)"
160160
TraceExit-Exception=Trc_VM_objectMonitorExit_Exit_IllegalFlatLock Overhead=1 Level=4 Template="objectMonitorExit (IllegalMonitorState in objectMonitorExit. Flat lock = %p, object=%p)"
@@ -1019,3 +1019,4 @@ TraceEntry=Trc_VM_getTypeId_Entry Overhead=1 Level=5 Template="getTypeId clazz=%
10191019
TraceExit=Trc_VM_getTypeId_Exit Overhead=1 Level=5 Template="getTypeId clazz=%p result=%lli"
10201020

10211021
TraceEvent=Trc_systemPropertyIterator Overhead=1 Level=10 Template="systemPropertyIterator: added VM system property '%s'='%s'"
1022+
TraceExit-Exception=Trc_VM_objectMonitorExit_Exit_LearningStateUnowned Overhead=1 Level=4 Template="objectMonitorExit (IllegalMonitorState: Lock in learning state but unowned. Flat lock=%p, object=%p)"

runtime/vm/monhelpers.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ objectMonitorExit(J9VMThread* vmStruct, j9object_t object)
115115
}
116116
} else if (count & OBJECT_HEADER_LOCK_LEARNING) {
117117
/* Lock is in Learning state but unowned (if it were owned it would have been caught by the first Learning state check) */
118+
Trc_VM_objectMonitorExit_Exit_LearningStateUnowned(vmStruct, lock, object);
118119
goto done;
119120
} else if (count >= OBJECT_HEADER_LOCK_FIRST_RECURSION_BIT) {
120121
/* just decrement the flatlock recursion count */

0 commit comments

Comments
 (0)