revert: remove runtime changes; keep memory benchmark and docs only

Co-Authored-By: Harry Brundage <[email protected]>

Author: devin-ai-integration[bot]

Benchmarking.md

@@ -91,6 +91,7 @@ node --expose-gc -r ts-node/register/transpile-only bench/memory-large-root.benc
 # control number of instances retained
 MQT_MEMORY_N=20 pnpm x bench/memory-large-root.benchmark.ts
 ```
+
 Notes:
 - In CI (CI=true) and CodSpeed runs, heap snapshots are disabled automatically to avoid environment limitations. Override locally with MQT_MEMORY_HEAPSNAP=1 if needed.
 

src/api.ts

@@ -27,7 +27,7 @@ import {
 } from "mobx-state-tree";
 import type { FlowReturn } from "mobx-state-tree/dist/internal";
 import { CantRunActionError } from "./errors";
-import { $context, $parent, $quickType, $readOnly, $type, $identifier } from "./symbols";
+import { $context, $parent, $quickType, $readOnly, $type } from "./symbols";
 import type {
   CreateTypes,
   IAnyComplexType,
@@ -236,57 +236,7 @@ export function resolveIdentifier<T extends IAnyModelType>(
   if (!context) {
     throw new Error("can't resolve references in a readonly tree with no context");
   }
-  const cache = (context as any).referenceCache;
-  if (cache && typeof cache.get === "function") {
-    return cache.get(identifier) as Instance<T> | undefined;
-  }
-  const root: any = getRoot<IAnyType>(target);
-  const visited = new Set<any>();
-  const isTargetType = (node: any): boolean => {
-    try {
-      return (isType(type) ? type : (type as any)).is(node);
-    } catch {
-      return false;
-    }
-  };
-  const stack: any[] = [root];
-  while (stack.length) {
-    const node = stack.pop();
-    if (!node || typeof node !== "object" || visited.has(node)) continue;
-    visited.add(node);
-    if ($readOnly in node) {
-      const id = node[$identifier];
-      if (id === identifier && isTargetType(node)) {
-        return node as Instance<T>;
-      }
-      for (const key of Object.keys(node)) {
-        const val = node[key];
-        if (val && typeof val === "object") {
-          stack.push(val);
-        }
-      }
-      if (Array.isArray(node)) {
-        for (const val of node) stack.push(val);
-      }
-      if (node instanceof Map) {
-        for (const val of node.values()) stack.push(val);
-      }
-    } else {
-      for (const key of Object.keys(node)) {
-        const val = node[key];
-        if (val && typeof val === "object") {
-          stack.push(val);
-        }
-      }
-      if (Array.isArray(node)) {
-        for (const val of node) stack.push(val);
-      }
-      if (node instanceof Map) {
-        for (const val of node.values()) stack.push(val);
-      }
-    }
-  }
-  return undefined as Instance<T> | undefined;
+  return context.referenceCache.get(identifier) as Instance<T> | undefined;
 }
 
 export const applySnapshot = <T extends IAnyType>(target: IStateTreeNode<T>, snapshot: SnapshotIn<T>): void => {

src/fast-instantiator.ts

@@ -113,13 +113,7 @@ export class InstantiatorBuilder<T extends IClassModelType<Record<string, IAnyTy
             }
           }
 
-          context.referencesToResolve = null; // cleanup the list of references to resolve, no need to retain them past construction
-          if (!(process && process.env && process.env.MQT_KEEP_REF_CACHE)) {
-            if (context.referenceCache && typeof context.referenceCache.clear === "function") {
-              context.referenceCache.clear();
-            }
-            context.referenceCache = null;
-          }
+          context.referencesToResolve = null;
 
           return instance;
         };

src/reference.ts

@@ -32,11 +32,10 @@ export class ReferenceType<TargetType extends IAnyComplexType> extends BaseType<
   }
 
   instantiate(snapshot: this["InputType"] | undefined, context: TreeContext, _parent: IStateTreeNode | null): this["InstanceType"] {
-    const cache = context.referenceCache;
-    if (!snapshot || !cache || !cache.has(snapshot)) {
+    if (!snapshot || !context.referenceCache.has(snapshot)) {
       throw new Error(`can't resolve reference ${snapshot}`);
     }
-    return cache.get(snapshot);
+    return context.referenceCache.get(snapshot);
   }
 
   is(value: any): value is this["InstanceType"];
@@ -62,11 +61,10 @@ export class SafeReferenceType<TargetType extends IAnyComplexType> extends BaseT
   }
 
   instantiate(snapshot: string | undefined, context: TreeContext, _parent: IStateTreeNode | null): this["InstanceType"] {
-    const cache = context.referenceCache;
-    if (!snapshot || !cache || !cache.has(snapshot)) {
+    if (!snapshot || !context.referenceCache.has(snapshot)) {
       return undefined as this["InstanceType"];
     }
-    return cache.get(snapshot);
+    return context.referenceCache.get(snapshot);
   }
 
   is(value: any): value is this["InstanceType"];