[eslint-refiner] ESLint Refiner — Daily Report 2026-06-27 #41965
Closed
Replies: 2 comments
-
|
Smoke test ping from run 28304424716. Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
This discussion has been marked as outdated by ESLint Refiner. A newer discussion is available at Discussion #42018. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Overview
Reviewed the
actions/setup/js/eslint-factoryrule set and the JavaScript targets it lints. The factory currently ships a single rule,require-json-parse-try-catch(configured aswarn). Static analysis surfaced three concrete, non-duplicate refinement opportunities; three issues were filed with acceptance criteria. No live lint run was possible this cycle (npm/network blocked, nonode_modules/dist), so findings are source-level.Key metrics
require-json-parse-try-catch).cjstargetsJSON.parse.then/.on/setTimeout/...)JSON.parseusages foundRefinement tasks filed
JSON.parseaccess is invisible to the rule (P1, false negative) —JSON["parse"](x), aliased, and destructured bindings bypass the matcher. Preventive hardening (0 current occurrences).JSON.parseinside a.then/.on/setTimeoutcallback defined in a try is wrongly treated as protected, while synchronous.map/.forEachcallbacks must stay safe.suggestfix, enrich the message with the parsed argument text, and reference the repo's existing safe-parse helpers (parseJsonWithRepair,parseJsonlContent).Methodology & limitations
eslint.config.cjs; reasoned about AST matching against real.cjspatterns sampled fromadd_comment.cjs,ai_credits_context.cjs,collect_ndjson_output.cjs, andjsonl_helpers.cjs.getAncestors().some(...)covers inner try blocks).npm run lint:setup-js: sandbox blocks npm/network and there is no committeddist/node_modules. A CI-side diagnostics export would let future runs work from real findings rather than static analysis.strategy.json,history.jsonl) and validated viapush_repo_memory(2 files, 3 KB).Next actions
Beta Was this translation helpful? Give feedback.
All reactions