remove compare to latest schema version feature flag (#7584)

Author: n1ru4l

.changeset/slimy-trams-search.md

@@ -0,0 +1,9 @@
+---
+'hive': minor
+---
+
+Enable automatic retrieval of schema changes by comparing with the latest composable version. This has already been the default for new projects created after April 2024. 
+
+Federation and schema stitching projects can now publish service schemas to the registry even if those schemas would break composition. This has also been the default behavior for new projects created after April 2024.
+
+To ensure every version publishd to the schema registry is composable, we recommend to first check the schema against the registry **before** publishing.

integration-tests/tests/api/artifacts-cdn.spec.ts

@@ -1117,11 +1117,10 @@ function runArtifactsCDNTests(
       'access versioned contract artifact with valid credentials',
       async ({ expect }) => {
         const { createOrg, ownerToken } = await initSeed().createOwner();
-        const { createProject, setFeatureFlag } = await createOrg();
-        const { createTargetAccessToken, createCdnAccess, target, setNativeFederation } =
-          await createProject(ProjectType.Federation);
-        await setFeatureFlag('compareToPreviousComposableVersion', true);
-        await setNativeFederation(true);
+        const { createProject } = await createOrg();
+        const { createTargetAccessToken, createCdnAccess, target } = await createProject(
+          ProjectType.Federation,
+        );
 
         const writeToken = await createTargetAccessToken({});
 

integration-tests/tests/api/schema/check.spec.ts

@@ -1925,12 +1925,8 @@ describe.concurrent(
   () => {
     test.concurrent('native federation', async () => {
       const { createOrg } = await initSeed().createOwner();
-      const { createProject, setFeatureFlag } = await createOrg();
-      const { createTargetAccessToken, setNativeFederation } = await createProject(
-        ProjectType.Federation,
-      );
-      await setFeatureFlag('compareToPreviousComposableVersion', true);
-      await setNativeFederation(true);
+      const { createProject } = await createOrg();
+      const { createTargetAccessToken } = await createProject(ProjectType.Federation);
 
       const token = await createTargetAccessToken({});
 
@@ -1976,11 +1972,10 @@ describe.concurrent(
 
     test.concurrent('legacy fed composition', async () => {
       const { createOrg } = await initSeed().createOwner();
-      const { createProject, setFeatureFlag } = await createOrg();
+      const { createProject } = await createOrg();
       const { createTargetAccessToken, setNativeFederation } = await createProject(
         ProjectType.Federation,
       );
-      await setFeatureFlag('compareToPreviousComposableVersion', false);
       await setNativeFederation(false);
 
       const token = await createTargetAccessToken({});
@@ -2020,58 +2015,6 @@ describe.concurrent(
         }),
       });
     });
-
-    test.concurrent(
-      'legacy fed composition with compareToPreviousComposableVersion=true',
-      async () => {
-        const { createOrg } = await initSeed().createOwner();
-        const { createProject, setFeatureFlag } = await createOrg();
-        const { createTargetAccessToken, setNativeFederation } = await createProject(
-          ProjectType.Federation,
-        );
-        await setFeatureFlag('compareToPreviousComposableVersion', true);
-        await setNativeFederation(false);
-
-        const token = await createTargetAccessToken({});
-
-        // @key(fields:) is invalid - should trigger a composition error
-        const sdl = /* GraphQL */ `
-          type Query {
-            ping: String
-            pong: String
-            foo: User
-          }
-
-          type User @key(fields: "uuid") {
-            id: ID!
-          }
-        `;
-
-        // Publish schema with write rights
-        await token
-          .publishSchema({
-            sdl,
-            service: 'serviceA',
-            url: 'http://localhost:4000',
-          })
-          .then(r => r.expectNoGraphQLErrors());
-
-        const result = await token
-          .checkSchema(sdl, 'serviceA')
-          .then(r => r.expectNoGraphQLErrors());
-
-        expect(result.schemaCheck).toMatchObject({
-          valid: false,
-          __typename: 'SchemaCheckError',
-          changes: expect.objectContaining({
-            total: 0,
-          }),
-          errors: expect.objectContaining({
-            total: 1,
-          }),
-        });
-      },
-    );
   },
 );
 

integration-tests/tests/api/schema/contracts-check.spec.ts

@@ -32,12 +32,8 @@ const CreateContractMutation = graphql(`
 
 test.concurrent('schema check with successful contract checks', async ({ expect }) => {
   const { createOrg, ownerToken } = await initSeed().createOwner();
-  const { createProject, setFeatureFlag } = await createOrg();
-  const { createTargetAccessToken, target, setNativeFederation } = await createProject(
-    ProjectType.Federation,
-  );
-  await setFeatureFlag('compareToPreviousComposableVersion', true);
-  await setNativeFederation(true);
+  const { createProject } = await createOrg();
+  const { createTargetAccessToken, target } = await createProject(ProjectType.Federation);
 
   // Create a token with write rights
   const writeToken = await createTargetAccessToken({});
@@ -99,12 +95,8 @@ test.concurrent('schema check with successful contract checks', async ({ expect
 
 test.concurrent('schema check with failing contract composition', async ({ expect }) => {
   const { createOrg, ownerToken } = await initSeed().createOwner();
-  const { createProject, setFeatureFlag } = await createOrg();
-  const { createTargetAccessToken, target, setNativeFederation } = await createProject(
-    ProjectType.Federation,
-  );
-  await setFeatureFlag('compareToPreviousComposableVersion', true);
-  await setNativeFederation(true);
+  const { createProject } = await createOrg();
+  const { createTargetAccessToken, target } = await createProject(ProjectType.Federation);
 
   // Create a token with write rights
   const writeToken = await createTargetAccessToken({});
@@ -180,12 +172,8 @@ test.concurrent(
   'schema check with failing contract composition (multiple contracts)',
   async ({ expect }) => {
     const { createOrg, ownerToken } = await initSeed().createOwner();
-    const { createProject, setFeatureFlag } = await createOrg();
-    const { createTargetAccessToken, target, setNativeFederation } = await createProject(
-      ProjectType.Federation,
-    );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
+    const { createProject } = await createOrg();
+    const { createTargetAccessToken, target } = await createProject(ProjectType.Federation);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});
@@ -381,12 +369,10 @@ test.concurrent(
   'approve failed schema check that has breaking change in contract check -> updates the status to successful and attaches meta information to the breaking change',
   async ({ expect }) => {
     const { createOrg, ownerToken } = await initSeed().createOwner();
-    const { createProject, organization, setFeatureFlag } = await createOrg();
-    const { createTargetAccessToken, project, target, setNativeFederation } = await createProject(
+    const { createProject, organization } = await createOrg();
+    const { createTargetAccessToken, project, target } = await createProject(
       ProjectType.Federation,
     );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});
@@ -547,8 +533,6 @@ test.concurrent(
     const { createTargetAccessToken, project, target, setNativeFederation } = await createProject(
       ProjectType.Federation,
     );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});
@@ -739,12 +723,10 @@ test.concurrent(
   'approving a schema check with contextId containing breaking changes does not allow the changes for subsequent checks with a different contextId',
   async ({ expect }) => {
     const { createOrg, ownerToken } = await initSeed().createOwner();
-    const { createProject, organization, setFeatureFlag } = await createOrg();
-    const { createTargetAccessToken, project, target, setNativeFederation } = await createProject(
+    const { createProject, organization } = await createOrg();
+    const { createTargetAccessToken, project, target } = await createProject(
       ProjectType.Federation,
     );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});
@@ -928,12 +910,10 @@ test.concurrent(
   'subsequent schema check with shared contextId that contains new breaking changes that have not been approved fails',
   async ({ expect }) => {
     const { createOrg, ownerToken } = await initSeed().createOwner();
-    const { createProject, organization, setFeatureFlag } = await createOrg();
-    const { createTargetAccessToken, project, target, setNativeFederation } = await createProject(
+    const { createProject, organization } = await createOrg();
+    const { createTargetAccessToken, project, target } = await createProject(
       ProjectType.Federation,
     );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});
@@ -1128,12 +1108,10 @@ test.concurrent(
   'schema check that has no composition errors in contract check -> can be approved',
   async ({ expect }) => {
     const { createOrg, ownerToken } = await initSeed().createOwner();
-    const { createProject, organization, setFeatureFlag } = await createOrg();
-    const { createTargetAccessToken, project, target, setNativeFederation } = await createProject(
+    const { createProject, organization } = await createOrg();
+    const { createTargetAccessToken, project, target } = await createProject(
       ProjectType.Federation,
     );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});
@@ -1237,12 +1215,10 @@ test.concurrent(
   'schema check that has composition errors in contract check -> can not be approved',
   async ({ expect }) => {
     const { createOrg, ownerToken } = await initSeed().createOwner();
-    const { createProject, organization, setFeatureFlag } = await createOrg();
+    const { createProject, organization } = await createOrg();
     const { createTargetAccessToken, project, target, setNativeFederation } = await createProject(
       ProjectType.Federation,
     );
-    await setFeatureFlag('compareToPreviousComposableVersion', true);
-    await setNativeFederation(true);
 
     // Create a token with write rights
     const writeToken = await createTargetAccessToken({});