Skip to content

Add redis tls_enabled option#5884

Merged
n1ru4l merged 10 commits into
graphql-hive:mainfrom
andriihrachov:redis-tls
Nov 11, 2024
Merged

Add redis tls_enabled option#5884
n1ru4l merged 10 commits into
graphql-hive:mainfrom
andriihrachov:redis-tls

Conversation

@andriihrachov

Copy link
Copy Markdown
Contributor

This PR contains solution for fixing problems when deployed in AWS with encryption in transit enabled
Issue #2250

@andriihrachov andriihrachov changed the title Add redis tls option Add redis tls_enabled option Nov 10, 2024
Comment thread packages/services/api/src/modules/shared/providers/redis.ts Outdated
Comment thread packages/services/tokens/src/environment.ts Outdated
Comment thread packages/services/server/src/environment.ts Outdated
Comment thread packages/services/webhooks/src/environment.ts Outdated

@n1ru4l n1ru4l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andriihrachov, thank you for this contribution. I added a few comments!

@n1ru4l

n1ru4l commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

Thank you @andriihrachov!
I pushed this PR branch here for running tests: #5890

@n1ru4l

n1ru4l commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

@andriihrachov Please have a look at the failed typescript checks

@n1ru4l n1ru4l mentioned this pull request Nov 11, 2024
14 tasks
@andriihrachov

Copy link
Copy Markdown
Contributor Author

thanks, fixed those

Comment thread docs/DEVELOPMENT.md
@andriihrachov andriihrachov requested a review from n1ru4l November 11, 2024 12:04
@n1ru4l

n1ru4l commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

@andriihrachov Can you please add a changeset file using pnpm changeset for hive?

@andriihrachov

Copy link
Copy Markdown
Contributor Author

@andriihrachov Can you please add a changeset file using pnpm changeset for hive?

added.

Comment thread packages/services/webhooks/src/index.ts Outdated
Comment thread .changeset/early-otters-help.md Outdated
Comment thread .changeset/early-otters-help.md Outdated
@n1ru4l n1ru4l merged commit 8aec41a into graphql-hive:main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants