chore: enable more rules from go-critic (#7434)

## Description of the changes
- Enable more rules from go-critic

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -71,18 +71,13 @@ linters:
         - deferInLoop
         - dupArg
         - exitAfterDefer
-        - exposedSyncMutex
         - hugeParam
         - importShadow
-        - nestingReduce
-        - paramTypeCombine
+        - paramTypeCombine # WON'T FIX
         - rangeValCopy
-        - regexpSimplify
         - returnAfterHttpError
         - todoCommentWithoutDetail
-        - typeAssertChain
         - unnamedResult
-        - whyNoLint
       enable-all: true
     gosec:
       excludes:

cmd/collector/app/collector.go

@@ -149,7 +149,7 @@ func (c *Collector) Start(options *flags.CollectorOptions) error {
 
 func (*Collector) publishOpts(cOpts *flags.CollectorOptions) {
 	safeexpvar.SetInt(metricNumWorkers, int64(cOpts.NumWorkers))
-	//nolint: gosec // G115
+	//nolint:gosec // G115
 	safeexpvar.SetInt(metricQueueSize, int64(cOpts.QueueSize))
 }
 

cmd/collector/app/queue/bounded_queue.go

@@ -43,7 +43,7 @@ func NewBoundedQueue[T any](capacity int, onDroppedItem func(item T)) *BoundedQu
 		stopCh:        make(chan struct{}),
 	}
 	bq.items.Store(&queue)
-	//nolint: gosec // G115
+	//nolint:gosec // G115
 	bq.capacity.Store(uint32(capacity))
 	return bq
 }
@@ -187,7 +187,7 @@ func (q *BoundedQueue[T]) Resize(capacity int) bool {
 		close(*previous)
 
 		// update the capacity
-		//nolint: gosec // G115
+		//nolint:gosec // G115
 		q.capacity.Store(uint32(capacity))
 	}
 

cmd/collector/app/span_handler_builder.go

@@ -49,7 +49,7 @@ func (b *SpanHandlerBuilder) BuildSpanProcessor(additional ...ProcessSpan) (proc
 		Options.Logger(b.logger()),
 		Options.SpanFilter(defaultSpanFilter),
 		Options.NumWorkers(b.CollectorOpts.NumWorkers),
-		//nolint: gosec // G115
+		//nolint:gosec // G115
 		Options.QueueSize(int(b.CollectorOpts.QueueSize)),
 		Options.CollectorTags(b.CollectorOpts.CollectorTags),
 		Options.DynQueueSizeWarmup(b.CollectorOpts.QueueSize), // same as queue size for now

cmd/collector/app/span_processor.go

@@ -232,7 +232,7 @@ func (sp *spanProcessor) writeSpan(ctx context.Context, span *model.Span) error
 }
 
 func (sp *spanProcessor) countSpansInQueue(span *model.Span, _ string /* tenant */) {
-	//nolint: gosec // G115
+	//nolint:gosec // G115
 	sp.bytesProcessed.Add(uint64(span.Size()))
 	sp.spansProcessed.Add(1)
 }
@@ -394,7 +394,7 @@ func (sp *spanProcessor) updateQueueSize() {
 }
 
 func (sp *spanProcessor) updateGauges() {
-	//nolint: gosec // G115
+	//nolint:gosec // G115
 	sp.metrics.SpansBytes.Update(int64(sp.bytesProcessed.Load()))
 	sp.metrics.QueueLength.Update(int64(sp.queue.Size()))
 	sp.metrics.QueueCapacity.Update(int64(sp.queue.Capacity()))

cmd/jaeger/internal/extension/remotesampling/extension.go

@@ -169,8 +169,7 @@ func (ext *rsExtension) startFileBasedStrategyProvider(_ context.Context) error
 		DefaultSamplingProbability: ext.cfg.File.DefaultSamplingProbability,
 	}
 
-	// contextcheck linter complains about next line that context is not passed.
-	//nolint:contextcheck
+	//nolint:contextcheck // contextcheck linter complains about next line that context is not passed.
 	provider, err := file.NewProvider(opts, ext.telemetry.Logger)
 	if err != nil {
 		return fmt.Errorf("failed to create the local file strategy store: %w", err)

cmd/jaeger/internal/integration/trace_reader.go

@@ -126,7 +126,7 @@ func (r *traceReader) FindTraces(
 				StartTimeMax:  query.StartTimeMax,
 				DurationMin:   query.DurationMin,
 				DurationMax:   query.DurationMax,
-				//nolint: gosec // G115
+				//nolint:gosec // G115
 				SearchDepth: int32(query.SearchDepth),
 				RawTraces:   true,
 			},

cmd/query/app/apiv3/http_gateway.go

@@ -95,7 +95,7 @@ func (h *HTTPGateway) tryHandleError(w http.ResponseWriter, err error, statusCod
 	}
 	errorResponse := api_v3.GRPCGatewayError{
 		Error: &api_v3.GRPCGatewayError_GRPCGatewayErrorDetails{
-			//nolint: gosec // G115
+			//nolint:gosec // G115
 			HttpCode: int32(statusCode),
 			Message:  err.Error(),
 		},

cmd/query/app/querysvc/internal/adjuster/clockskew.go

@@ -74,7 +74,7 @@ func hostKey(span *model.Span) string {
 		if tag.VType == model.Int64Type {
 			var buf [4]byte // avoid heap allocation
 			ip := buf[0:4]  // utils require a slice, not an array
-			//nolint: gosec // G115
+			//nolint:gosec // G115
 			binary.BigEndian.PutUint32(ip, uint32(tag.Int64()))
 			return net.IP(ip).String()
 		}

cmd/query/app/querysvc/internal/adjuster/ip_tag.go

@@ -26,7 +26,7 @@ func IPTagAdjuster() Adjuster {
 			var value uint32
 			switch tag.VType {
 			case model.Int64Type:
-				//nolint: gosec // G115
+				//nolint:gosec // G115
 				value = uint32(tag.Int64())
 			case model.Float64Type:
 				value = uint32(tag.Float64())