Skip to content

Commit 03b476f

Browse files
committed
Minor small-string errata from #1199
These commits were sitting on a local branch that I neglected to push before merging. :( * Use memcpy for string::reserve * Remove fence comments
1 parent 8b3e368 commit 03b476f

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

ctl/string.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ string::reserve(size_t c2) noexcept
9999
if (!isbig()) {
100100
if (!(p2 = (char*)malloc(c2)))
101101
__builtin_trap();
102-
__builtin_memcpy(p2, data(), size() + 1);
102+
memcpy(p2, data(), size() + 1);
103103
} else {
104104
if (!(p2 = (char*)realloc(big()->p, c2)))
105105
__builtin_trap();
@@ -139,7 +139,6 @@ string::append(char ch) noexcept
139139
__builtin_trap();
140140
reserve(c2);
141141
}
142-
// XXX do we care to fence this?
143142
data()[size()] = ch;
144143
data()[size() + 1] = 0;
145144
if (isbig()) {
@@ -174,7 +173,6 @@ string::append(char ch, size_t size) noexcept
174173
grow(size);
175174
if (size)
176175
memset(data() + this->size(), ch, size);
177-
// XXX fence?
178176
if (isbig()) {
179177
big()->n += size;
180178
} else {

0 commit comments

Comments
 (0)