make_shared should work with nontrivial objects (#1293)

mrdomino · web-flow · commit 37e2660c7fb4 · 2024-09-15T01:18:19.000-07:00
diff --git a/ctl/shared_ptr.h b/ctl/shared_ptr.h
@@ -147,6 +147,10 @@ class shared_emplace : public shared_ref
         T t;
     };
 
+    ~shared_emplace() override
+    {
+    }
+
     template<typename... Args>
     void construct(Args&&... args)
     {
@@ -159,7 +163,9 @@ class shared_emplace : public shared_ref
     }
 
   private:
-    explicit constexpr shared_emplace() noexcept = default;
+    explicit constexpr shared_emplace() noexcept
+    {
+    }
 
     void dispose() noexcept override
     {

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,10 @@ class shared_emplace : public shared_ref`
`147`	`147`	`T t;`
`148`	`148`	`};`
`149`	`149`
	`150`	`+ ~shared_emplace() override`
	`151`	`+ {`
	`152`	`+ }`
	`153`	`+`
`150`	`154`	`template<typename... Args>`
`151`	`155`	`void construct(Args&&... args)`
`152`	`156`	`{`
`@@ -159,7 +163,9 @@ class shared_emplace : public shared_ref`
`159`	`163`	`}`
`160`	`164`
`161`	`165`	`private:`
`162`		`- explicit constexpr shared_emplace() noexcept = default;`
	`166`	`+ explicit constexpr shared_emplace() noexcept`
	`167`	`+ {`
	`168`	`+ }`
`163`	`169`
`164`	`170`	`void dispose() noexcept override`
`165`	`171`	`{`