From 5f76d9172ebce4b9ebf0abff1288799614c77bc3 Mon Sep 17 00:00:00 2001 From: Aaron van Meerten Date: Thu, 27 Feb 2025 06:38:19 -0600 Subject: [PATCH 1/2] feat(jibri): move to separate parameters for video encode presets --- jibri/rootfs/defaults/jibri.conf | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/jibri/rootfs/defaults/jibri.conf b/jibri/rootfs/defaults/jibri.conf index c3faaa2d27..aa62f16ee0 100644 --- a/jibri/rootfs/defaults/jibri.conf +++ b/jibri/rootfs/defaults/jibri.conf @@ -1,7 +1,8 @@ {{ $IGNORE_CERTIFICATE_ERRORS := .Env.IGNORE_CERTIFICATE_ERRORS | default "false" | toBool -}} {{ $ENABLE_PROMETHEUS := .Env.JIBRI_ENABLE_PROMETHEUS | default "false" | toBool -}} {{ $JIBRI_RECORDING_RESOLUTION := .Env.JIBRI_RECORDING_RESOLUTION | default "1280x720" -}} -{{ $JIBRI_RECORDING_VIDEO_ENCODE_PRESET := .Env.JIBRI_RECORDING_VIDEO_ENCODE_PRESET | default "veryfast" -}} +{{ $JIBRI_RECORDING_VIDEO_ENCODE_PRESET_RECORDING := .Env.JIBRI_RECORDING_VIDEO_ENCODE_PRESET_RECORDING | default "ultrafast" -}} +{{ $JIBRI_RECORDING_VIDEO_ENCODE_PRESET_STREAMING := .Env.JIBRI_RECORDING_VIDEO_ENCODE_PRESET_STREAMING | default "veryfast" -}} {{ $JIBRI_RECORDING_CONSTANT_RATE_FACTOR := .Env.JIBRI_RECORDING_CONSTANT_RATE_FACTOR | default 25 -}} {{ $JIBRI_RECORDING_FRAMERATE := .Env.JIBRI_RECORDING_FRAMERATE | default 30 -}} {{ $JIBRI_RECORDING_QUEUE_SIZE := .Env.JIBRI_RECORDING_QUEUE_SIZE | default 4096 -}} @@ -52,7 +53,9 @@ jibri { streaming-max-bitrate = {{ $JIBRI_RECORDING_STREAMING_MAX_BITRATE }} // Available presets: ultrafast, superfast, veryfast, faster, fast, medium, // slow, slower, veryslow, placebo - video-encode-preset = "{{ $JIBRI_RECORDING_VIDEO_ENCODE_PRESET }}" + video-encode-preset-streaming = "{{ $JIBRI_RECORDING_VIDEO_ENCODE_PRESET_STREAMING }}" + video-encode-preset-recording = "{{ $JIBRI_RECORDING_VIDEO_ENCODE_PRESET_RECORDING }}" + // The range of the CRF scale is 0-51, where 0 is lossless, // 23 is the default, and 51 is worst quality possible. h264-constant-rate-factor = {{ $JIBRI_RECORDING_CONSTANT_RATE_FACTOR }} From 43898ffc8c69768fa480c08ba464e77101929699 Mon Sep 17 00:00:00 2001 From: Aaron van Meerten Date: Thu, 27 Feb 2025 06:51:24 -0600 Subject: [PATCH 2/2] compose vars --- jibri.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jibri.yml b/jibri.yml index 8257b7531a..c6a08d478b 100644 --- a/jibri.yml +++ b/jibri.yml @@ -30,7 +30,8 @@ services: - JIBRI_HTTP_API_EXTERNAL_PORT - JIBRI_HTTP_API_INTERNAL_PORT - JIBRI_RECORDING_RESOLUTION - - JIBRI_RECORDING_VIDEO_ENCODE_PRESET + - JIBRI_RECORDING_VIDEO_ENCODE_PRESET_RECORDING + - JIBRI_RECORDING_VIDEO_ENCODE_PRESET_STREAMING - JIBRI_RECORDING_CONSTANT_RATE_FACTOR - JIBRI_RECORDING_FRAMERATE - JIBRI_RECORDING_QUEUE_SIZE