Skip to content

Commit d029254

Browse files
authored
Reduce dependencies between steps
1 parent 623f9a1 commit d029254

File tree

1 file changed

+7
-23
lines changed

1 file changed

+7
-23
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
name: Check PHP code style
5858
runs-on: ubuntu-latest
5959
container: joomlaprojects/docker-images:php8.4
60-
needs: [composer, npm]
60+
needs: [composer]
6161
steps:
6262
- uses: actions/checkout@v4
6363
- uses: actions/cache/restore@v4
@@ -71,8 +71,8 @@ jobs:
7171
./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff
7272
./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .
7373
74-
code-style-js:
75-
name: Check Javascript code style
74+
code-style-js-css:
75+
name: Check Javascript & CSS code style
7676
runs-on: ubuntu-latest
7777
container: joomlaprojects/docker-images:php8.4
7878
needs: [composer, npm]
@@ -91,23 +91,6 @@ jobs:
9191
run: |
9292
npm run lint:js
9393
npm run lint:testjs
94-
95-
code-style-css:
96-
name: Check CSS code style
97-
runs-on: ubuntu-latest
98-
container: joomlaprojects/docker-images:php8.4
99-
needs: [composer, npm]
100-
steps:
101-
- uses: actions/setup-node@v4
102-
with:
103-
node-version: latest
104-
- uses: actions/checkout@v4
105-
- uses: actions/cache/restore@v4
106-
with:
107-
path: |
108-
node_modules
109-
media
110-
key: ${{ runner.os }}-node-${{ hashFiles('package-lock.json', 'build/media_source/**', 'administrator/components/com_media/resources/**') }}
11194
- name: Check CSS code style
11295
run: npm run lint:css
11396

@@ -130,7 +113,7 @@ jobs:
130113
name: Run Unit tests
131114
runs-on: ubuntu-latest
132115
container: joomlaprojects/docker-images:php${{ matrix.php_version }}
133-
needs: [code-style-php, code-style-js, code-style-css]
116+
needs: [code-style-php]
134117
strategy:
135118
matrix:
136119
php_version: ['8.1', '8.2', '8.3', '8.4']
@@ -147,7 +130,7 @@ jobs:
147130
name: Run integration tests
148131
runs-on: ubuntu-latest
149132
container: joomlaprojects/docker-images:php${{ matrix.php_version }}
150-
needs: [code-style-php, code-style-js, code-style-css]
133+
needs: [code-style-php]
151134
strategy:
152135
matrix:
153136
php_version: ['8.1', '8.2', '8.3', '8.4']
@@ -189,6 +172,7 @@ jobs:
189172
name: Prepare system tests
190173
runs-on: ubuntu-latest
191174
container: joomlaprojects/docker-images:cypress8.4
175+
needs: [composer, npm]
192176
env:
193177
CYPRESS_VERIFY_TIMEOUT: 100000
194178
steps:
@@ -216,7 +200,7 @@ jobs:
216200
name: Run system tests
217201
runs-on: ubuntu-latest
218202
container: joomlaprojects/docker-images:cypress${{ matrix.config.php_version }}
219-
needs: [tests-system-prepare, tests-unit, tests-integration]
203+
needs: [tests-system-prepare]
220204
strategy:
221205
matrix:
222206
config:

0 commit comments

Comments
 (0)