Skip to content

Commit 8f4b81a

Browse files
authored
Update config to be compatible with pylint>=2.14 (#1595)
* Remove "bad-continuation" rule removed from pylint Signed-off-by: Deepyaman Datta <[email protected]> * Load "pylint.extensions.no_self_use" for `pylint>=2.14` Signed-off-by: Deepyaman Datta <[email protected]> * Ignore pylint warning from testing context manager Signed-off-by: Deepyaman Datta <[email protected]> * Ignore the "unnecessary" lambda assignment warning Signed-off-by: Deepyaman Datta <[email protected]>
1 parent 435fe79 commit 8f4b81a

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

pyproject.toml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@ default_section = "THIRDPARTY"
1414
[tool.pylint.master]
1515
ignore = "CVS"
1616
ignore-patterns = "kedro/templates/*"
17-
load-plugins = "pylint.extensions.docparams"
17+
load-plugins = [
18+
"pylint.extensions.docparams",
19+
"pylint.extensions.no_self_use"
20+
]
1821
unsafe-load-any-extension = false
1922
[tool.pylint.messages_control]
2023
disable = [
2124
"ungrouped-imports",
22-
"bad-continuation",
2325
"duplicate-code"
2426
]
2527
enable = ["useless-suppression"]

tests/extras/datasets/pandas/test_hdf_dataset.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,10 @@ def test_thread_lock_usage(self, hdf_data_set, dummy_dataframe, mocker):
133133
mocked_lock.assert_not_called()
134134

135135
hdf_data_set.save(dummy_dataframe)
136-
calls = [mocker.call.__enter__(), mocker.call.__exit__(None, None, None)]
136+
calls = [
137+
mocker.call.__enter__(), # pylint: disable=unnecessary-dunder-call
138+
mocker.call.__exit__(None, None, None),
139+
]
137140
mocked_lock.assert_has_calls(calls)
138141

139142
mocked_lock.reset_mock()

tests/pipeline/test_node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ def dummy_func_args(**kwargs):
300300
return dummy_func_args, "A", "B"
301301

302302

303-
lambda_identity = lambda input1: input1 # noqa: disable=E731
303+
lambda_identity = lambda input1: input1 # noqa: disable=E731 # pylint: disable=C3001
304304

305305

306306
def lambda_inconsistent_input_size():

0 commit comments

Comments
 (0)