Skip to content

test(utils): cover natural_sort and file pattern expand#10314

Closed
Bartok9 wants to merge 2 commits into
marimo-team:mainfrom
Bartok9:top10/test-utils-files-natural-sort
Closed

test(utils): cover natural_sort and file pattern expand#10314
Bartok9 wants to merge 2 commits into
marimo-team:mainfrom
Bartok9:top10/test-utils-files-natural-sort

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 23, 2026

Copy link
Copy Markdown

This pull request was authored by a coding agent.

AI-assisted; human-reviewed by the campaign operator before submit.

Summary

  • Unit tests for natural_sort, _get_root, and expand_file_patterns
  • Locks numeric filename ordering (file2 < file10) and skip of hidden/dot directories

Motivation

File-browser / batch path expansion relies on these helpers. Pure tests only — no runtime behavior change. Addresses coverage gap adjacent to workspace listing concerns without UX/ready product work.

Verification

  • Offline importlib runner — 7 passed (test_files.py)
  • Covers temp dirs for expand; pure keys for natural_sort

Checklist notes

  • Draft + agent disclosure
  • DCO -s
  • Human review prior to push

Agent-Owner: sera · Platform: hermes · Claim-TTL: 24h

Lock numeric filename ordering and directory expand (including skip of dotdirs).

Signed-off-by: Bartok9 <danielrpike9@gmail.com>
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jul 23, 2026 11:00pm

Request Review

@Bartok9

Bartok9 commented Jul 23, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@Light2Dark

Copy link
Copy Markdown
Member

hello! please don't create unecessary PRs. I'd recommend filing an issue first for features/bugs you'd like

@Light2Dark Light2Dark closed this Jul 24, 2026
@Bartok9

Bartok9 commented Jul 24, 2026

Copy link
Copy Markdown
Author

Understood, and apologies for the noise — thanks for the guidance. I'll file an issue first to check interest before opening any test/coverage PRs going forward. Appreciate your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants