powerplatform environment support for creating environment without dataverese (#255)

* refarctoring environment datasource

* wip

* refactoring powerplatform_environment

* refactoring template metadata

* Refactoring environment datasource

* Squashed commit of the following:

commit 08f8476
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Apr 10 08:17:36 2024 +0200

    Bump github.com/Azure/azure-sdk-for-go/sdk/azidentity (#254)

    Bumps [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) from 1.5.1 to 1.5.2.
    - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
    - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
    - [Commits](Azure/azure-sdk-for-go@sdk/internal/v1.5.1...sdk/internal/v1.5.2)

    ---
    updated-dependencies:
    - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit e255409
Author: mawasile <[email protected]>
Date:   Mon Apr 8 18:47:07 2024 +0200

    Adding powerplatform_environment_settings resource and datasource (#250)

    * Add new Environment Settings data source

    * adding unit tests

    * Add environment settings resource and data source

    * adding unit tests

    * Squashed commit of the following:

    commit 34468d7
    Author: Engin Polat <[email protected]>
    Date:   Fri Mar 22 10:16:34 2024 -0700

        creating languages data source (#237)

        * creating language data source

        * adding languages data source to provider

        * changing languages data source example to use cli to authenticate

        * updating model and api for languages

        * adding documentation

        * adding tests

    * Update ProtoV6ProviderFactories in unit test

    * Update ProtoV6ProviderFactories in unit test

    * Refactor API calls in environment settings tests

    * Update user.md and resource_user.go with additional resources

    * Refactor power platform environment settings

    * Add power_apps_component_framework_for_canvas_apps feature to powerplatform_environment_settings resource and datasource

    * Update ImportState function to use environment_id instead of id

    * Delete import.tf file

    ---------

    Co-authored-by: Matt Dotson <[email protected]>

commit 0223f4b
Author: Matt Dotson <[email protected]>
Date:   Thu Apr 4 11:02:52 2024 -0700

    more precise login command (#253)

commit 8f6a60e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Apr 4 11:01:33 2024 -0700

    Bump github.com/Azure/azure-sdk-for-go/sdk/azcore from 1.11.0 to 1.11.1 (#251)

    Bumps [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) from 1.11.0 to 1.11.1.
    - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
    - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
    - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.11.0...sdk/azcore/v1.11.1)

    ---
    updated-dependencies:
    - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Refactoring dataverse attribute for environment

* no dataverse use case for solution import

* refactoing managed environment when no dataverse is present

* handling no dataverse when using environment_settings

* refactoring application packages install to handle no dataverse environments

* refactoring application package install to work when no dataverse is present

* supporting no dataverse in datasource solutions

* updating example

* refactoring unit tests and simplifing environment setup

* Refactoring code to handle no Dataverse environments

* Refactoring code to handle no Dataverse environments

* Refactoring code to handle no Dataverse environments

* fixing paths for unit test

* adding additional unit tests

Author: mawasile

docs/data-sources/environments.md

@@ -42,17 +42,26 @@ data "powerplatform_environments" "all_environments" {}
 Read-Only:
 
 - `billing_policy_id` (String) Billing policy id (guid) for pay-as-you-go environments using Azure subscription billing
-- `currency_code` (String) Unique currency name (EUR, USE, GBP etc.)
+- `dataverse` (Attributes) Dataverse environment details (see [below for nested schema](#nestedatt--environments--dataverse))
 - `display_name` (String) Display name
-- `domain` (String) Domain name of the environment
 - `environment_type` (String) Type of the environment (Sandbox, Production etc.)
 - `id` (String) Unique environment id (guid)
+- `location` (String) Location of the environment (europe, unitedstates etc.)
+
+<a id="nestedatt--environments--dataverse"></a>
+### Nested Schema for `environments.dataverse`
+
+Read-Only:
+
+- `currency_code` (String) Unique currency name (EUR, USE, GBP etc.)
+- `domain` (String) Domain name of the environment
 - `language_code` (Number) Unique language LCID (integer)
 - `linked_app_id` (String) Unique linked app id (guid)
 - `linked_app_type` (String) Type of the linked app (Internal, External etc.)
 - `linked_app_url` (String) URL of the linked D365 app
-- `location` (String) Location of the environment (europe, unitedstates etc.)
 - `organization_id` (String) Unique organization id (guid)
 - `security_group_id` (String) Unique security group id (guid)
+- `template_metadata` (String) Additional D365 environment template metadata (if any)
+- `templates` (List of String) The selected instance provisioning template (if any)
 - `url` (String) Url of the environment
 - `version` (String) Version of the environment

docs/index.md

@@ -57,7 +57,7 @@ The Power Platform provider can use the [Azure CLI](https://learn.microsoft.com/
 1. Login using the scope as the "expose API" you configured when creating the app registration
 
 ```bash
-az login --scope api://powerplatform_provider_terraform/access
+az login --allow-no-subscriptions --scope api://powerplatform_provider_terraform/.default
 ```
 
 Configure the provider to use the Azure CLI with the following code:

docs/resources/environment.md

@@ -36,13 +36,15 @@ provider "powerplatform" {
 }
 
 resource "powerplatform_environment" "development" {
-  display_name      = "example_environment"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  domain            = "mydomain"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "example_environment"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    domain            = "mydomain"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 ```
 
@@ -51,23 +53,36 @@ resource "powerplatform_environment" "development" {
 
 ### Required
 
-- `currency_code` (String) Unique currency name
 - `display_name` (String) Display name
 - `environment_type` (String) Type of the environment (Sandbox, Production etc.)
-- `language_code` (Number) Unique language LCID (integer)
 - `location` (String) Location of the environment (europe, unitedstates etc.)
-- `security_group_id` (String) Unique security group id (guid).  For an empty security group, set this property to `0000000-0000-0000-0000-000000000000`
 
 ### Optional
 
 - `billing_policy_id` (String) Billing policy id (guid) for pay-as-you-go environments using Azure subscription billing
+- `dataverse` (Attributes) Dataverse environment details (see [below for nested schema](#nestedatt--dataverse))
+
+### Read-Only
+
+- `id` (String) Unique environment id (guid)
+
+<a id="nestedatt--dataverse"></a>
+### Nested Schema for `dataverse`
+
+Required:
+
+- `currency_code` (String) Unique currency name
+- `language_code` (Number) Unique language LCID (integer)
+- `security_group_id` (String) Unique security group id (guid).  For an empty security group, set this property to `0000000-0000-0000-0000-000000000000`
+
+Optional:
+
 - `domain` (String) Domain name of the environment
 - `template_metadata` (String) Additional D365 environment template metadata (if any)
 - `templates` (List of String) The selected instance provisioning template (if any)
 
-### Read-Only
+Read-Only:
 
-- `id` (String) Unique environment id (guid)
 - `linked_app_id` (String) The GUID of the linked D365 application
 - `linked_app_type` (String) The type of the linked D365 application
 - `linked_app_url` (String) The URL of the linked D365 application
@@ -76,3 +91,4 @@ resource "powerplatform_environment" "development" {
 - `version` (String) Version of the environment
 
 
+

docs/resources/environment_settings.md

@@ -26,12 +26,14 @@ provider "powerplatform" {
 }
 
 resource "powerplatform_environment" "example_environment_settings" {
-  display_name      = "example_environment_settings"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "example_environment_settings"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 
 resource "powerplatform_environment_settings" "settings" {

docs/resources/managed_environment.md

@@ -26,12 +26,14 @@ provider "powerplatform" {
 }
 
 resource "powerplatform_environment" "development" {
-  display_name      = "example_managed_environment"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "example_managed_environment"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 
 resource "powerplatform_managed_environment" "managed_development" {

docs/resources/solution.md

@@ -61,12 +61,14 @@ EOF
 }
 
 resource "powerplatform_environment" "environment" {
-  display_name      = "Solution Import Test 1"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "Solution Import Test 1"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 
 resource "powerplatform_solution" "solution" {

docs/resources/user.md

@@ -63,12 +63,14 @@ resource "azuread_user" "test_user" {
 }
 
 resource "powerplatform_environment" "dataverse_user_example" {
-  display_name      = "user_example"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "user_example"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 
 resource "powerplatform_user" "new_user" {

examples/data-sources/powerplatform_environment_settings/datasource.tf

@@ -11,12 +11,14 @@ provider "powerplatform" {
 }
 
 resource "powerplatform_environment" "example_environment_settings" {
-  display_name      = "example_environment_settings"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "example_environment_settings"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 
 data "powerplatform_environment_settings" "settings" {

examples/data-sources/powerplatform_securityroles/data-source.tf

@@ -11,12 +11,14 @@ provider "powerplatform" {
 }
 
 resource "powerplatform_environment" "environment" {
-  display_name      = "datasource_security_roles_example"
-  location          = "europe"
-  language_code     = "1033"
-  currency_code     = "USD"
-  environment_type  = "Sandbox"
-  security_group_id = "00000000-0000-0000-0000-000000000000"
+  display_name     = "datasource_security_roles_example"
+  location         = "europe"
+  environment_type = "Sandbox"
+  dataverse = {
+    language_code     = "1033"
+    currency_code     = "USD"
+    security_group_id = "00000000-0000-0000-0000-000000000000"
+  }
 }
 
 data "powerplatform_security_roles" "all" {

examples/resources/powerplatform_environment/outputs.tf

@@ -10,5 +10,5 @@ output "id" {
 
 output "url" {
   description = "URL of the environment"
-  value       = powerplatform_environment.development.url
+  value       = powerplatform_environment.development.dataverse.url
 }