Skip to content

Fix: Update authorization header check in doRequest function #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mawasile
Copy link
Contributor

@mawasile mawasile commented Apr 7, 2025

This pull request includes a small but important change to the internal/api/request.go file. The change modifies the way the Authorization header is checked and set in the doRequest function.

  • internal/api/request.go: Changed the condition from checking if the Authorization header is nil to checking if it is an empty string.

@mawasile mawasile linked an issue Apr 7, 2025 that may be closed by this pull request
@mawasile mawasile marked this pull request as ready for review April 7, 2025 07:56
@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 07:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@mattdot mattdot merged commit 72f022e into main Apr 7, 2025
14 checks passed
@mattdot mattdot deleted the mawasile/685-case-sensitivity-issue-when-working-with-requestresponse-headers branch April 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

case sensitivity issue when working with request/response headers
2 participants