Skip to content

Commit 509032c

Browse files
ci: nix shell to unset GOROOT
Signed-off-by: Abhinandan Purkait <[email protected]>
1 parent 5e0a066 commit 509032c

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.github/workflows/branch_preparation.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ jobs:
2525
nix-shell --pure --run "./scripts/test-update-chart-version.sh" ./shell.nix
2626
- name: Modify the chart version based on the tag
2727
run: |
28-
nix-shell --pure ./shell.nix --run "./scripts/update-chart-version.sh --tag ${{ github.ref_name }} > /tmp/file"
29-
echo "BASE=$(cat /tmp/file)" >> $GITHUB_ENV
28+
nix-shell --pure ./shell.nix --run "./scripts/update-chart-version.sh --tag ${{ github.ref_name }} > /tmp/openebs-file"
29+
echo "BASE=$(cat /tmp/openebs-file)" >> $GITHUB_ENV
3030
- name: Create Pull Request to release
3131
if: ${{ env.BASE }}
3232
id: cpr

docs/developer-setup.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ While you rebase your changes, you must resolve any conflicts that might arise a
151151
Before starting, ensure you have installed all the dependencies.
152152
If you're using [nix], then simply enter the [nix-shell] which will setup a shell with all required packages:
153153

154+
NOTE: If you're using zsh plugin in nix-shell, make sure your zshrc configurations don't override the Go envs set by the nix-shell.
155+
154156
```sh
155157
$ nix-shell
156158
go: downloading ....

shell.nix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ pkgs.mkShell {
2828
PRE_COMMIT_ALLOW_NO_CONFIG = 1;
2929

3030
shellHook = ''
31+
unset GOROOT
3132
export GOPATH=$(pwd)/nix/.go
3233
export GOCACHE=$(pwd)/nix/.go/cache
3334
export TMPDIR=$(pwd)/nix/.tmp

0 commit comments

Comments
 (0)