Warning Icon for non-mandatory PR checks instead of 'X'

[ed0906]

In our team we use Github Actions to run Checks on PRs.
Some of the checks block a merge when they fail. Some other checks can fail but don't block a merge.
Github already offers this functionality which is great.

The trouble we have is the checks that fail which don't block merges still have a big ❌ beside them which can look like there's a problem, even when the check could just be prompting the reviewer to take action rather than the developer e.g. Review a particular file in more detail for backwards compatibility.
It also results in that PR having an ❌ against it on summary screens such as https://github.com/{org}/{repo}/pulls.
The above all acts as a deterrent to potential reviewers as it may look like the PR isnt ready for review.

I would like to propose the introduction of an option for PR checks to fail with a user configurable ❌ or an ⚠️ icon

---

An example of our use case

We have a Check which verifies if an open api spec has changed as part of a PR.
If that file has changed, the check currently fails which should prompt a reviewer to look at the changes to that file in detail for backwards compatibility.
The trouble is, from experience, when people see a ❌ they often think "The PR isn't ready for review" and stop their review, or hold off testing it.

If instead these optional checks could be configured to fail with ⚠️ , and that icon propagates to summary screens (providing all other mandatory checks pass) then I believe reviewers would be more likely to review PRs which are in fact ready for review, but have warnings/actions attached.

[knocte]

Some other checks can fail but don't block a merge.

How did you achieve this?

[ed0906]

I thought I had this set up in branch protection settings, but it could be that because I'm a project admin that I can merge anyway...

If thats not a feature already it probably should be as well

[ed0906]

Ignore the above this is possible.

Mandatory checks that block a merge: Use branch protection settings for master/whatever your main branch is called
Optional checks that dont block a merge: all other pr checks that arent in branch protection settings

The trouble is that even though what I call the Optional checks dont block a merge, they still have a big scary red ❌ next to them so whoever comes to review/merge may feel like something needs rectifying, when in fact it could just be a call to action e.g. "review the api spec", or "tell another team something is going to change"

[rousseldenis]

I should say +1 for such feature

related to isaacs/github#1465

[vpaulson]

Any chance this will ever get looked at? In particular the scary red X on the main /pulls page of the Repo confuses people thinking those pull requests are not mergable.

[fsmeier]

+1 - I thought we had this already, but maybe it was gitlab....

[zsolt-p]

+1 this would be great