metadata: validate min chunk length for jpeg

sscobici · sscobici · commit d8fb22067ed0 · 2025-01-15T20:41:46.000+02:00
diff --git a/symphonia-metadata/src/utils/images.rs b/symphonia-metadata/src/utils/images.rs
@@ -82,6 +82,9 @@ fn parse_jpeg(mut reader: BufReader<'_>) -> Result<ImageInfo> {
 
             return Ok(info);
         }
+        if chunk_len < 2 {
+            return decode_error("meta (jpeg): invalid chunk length");
+        }
 
         // Ignore the chunk. Exclude the chunk length that has already been read.
         reader.ignore_bytes(u64::from(chunk_len) - 2)?;

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,9 @@ fn parse_jpeg(mut reader: BufReader<'_>) -> Result<ImageInfo> {`
`82`	`82`
`83`	`83`	`return Ok(info);`
`84`	`84`	`}`
	`85`	`+ if chunk_len < 2 {`
	`86`	`+ return decode_error("meta (jpeg): invalid chunk length");`
	`87`	`+ }`
`85`	`88`
`86`	`89`	`// Ignore the chunk. Exclude the chunk length that has already been read.`
`87`	`90`	`reader.ignore_bytes(u64::from(chunk_len) - 2)?;`