feature: complete rework of how downloads/builder work

Signed-off-by: Valery Piashchynski <[email protected]>

Author: rustatian

.claude/CLAUDE.md

@@ -5,6 +5,7 @@
 *.so
 *.dylib
 .venv
+.DS_Store
 
 # Test binary, built with `go test -c`
 *.test

.gitignore

@@ -35,8 +35,6 @@ message PluginInfo {
 }
 
 message Plugin {
-  string name = 1 [(buf.validate.field).required = false]; // optional, if not set, ref+owner+repository will be used
-  string ref = 2 [(buf.validate.field).required = true]; // git ref, branch, tag, commit
-  string owner = 3 [(buf.validate.field).required = true]; // roadrunner-server
-  string repository = 4 [(buf.validate.field).required = true]; // static
+  string module_name = 1 [(buf.validate.field).required = true];
+  string tag = 2 [(buf.validate.field).required = true];
 }

api/request/v1/request.proto

@@ -7,7 +7,6 @@ import (
 	"math/rand"
 	"os"
 	"os/exec"
-	"path"
 	"path/filepath"
 	"regexp"
 	"strings"
@@ -133,22 +132,22 @@ func (b *Builder) Build(rrModule string) error { //nolint:gocyclo
 	}()
 
 	// remove old plugins.go
-	err = os.Remove(path.Join(b.rrTempPath, pluginsPath))
+	err = os.Remove(filepath.Join(b.rrTempPath, pluginsPath))
 	if err != nil {
 		return err
 	}
 
-	err = os.WriteFile(path.Join(b.rrTempPath, pluginsPath), buf.Bytes(), 0600)
+	err = os.WriteFile(filepath.Join(b.rrTempPath, pluginsPath), buf.Bytes(), 0600)
 	if err != nil {
 		return err
 	}
 
-	err = os.Remove(path.Join(b.rrTempPath, goModStr))
+	err = os.Remove(filepath.Join(b.rrTempPath, goModStr))
 	if err != nil {
 		return err
 	}
 
-	goModFile, err := os.Create(path.Join(b.rrTempPath, goModStr))
+	goModFile, err := os.Create(filepath.Join(b.rrTempPath, goModStr))
 	if err != nil {
 		return err
 	}
@@ -349,7 +348,7 @@ func (b *Builder) exec(cmd []string) error {
 
 func (b *Builder) getDepsReplace(repl string) []*templates.Entry {
 	b.log.Info("found replace, processing", zap.String("dependency", repl))
-	modFile, err := os.ReadFile(path.Join(repl, goModStr))
+	modFile, err := os.ReadFile(filepath.Join(repl, goModStr))
 	if err != nil {
 		return nil
 	}
@@ -367,7 +366,7 @@ func (b *Builder) getDepsReplace(repl string) []*templates.Entry {
 		moduleReplace := split[1]
 
 		if strings.HasPrefix(moduleReplace, ".") {
-			moduleReplace = path.Join(repl, moduleReplace)
+			moduleReplace = filepath.Join(repl, moduleReplace)
 		}
 
 		result = append(result, &templates.Entry{

builder/builder.go

@@ -2,7 +2,7 @@ package builder
 
 import (
 	"os"
-	"path"
+	"path/filepath"
 	"testing"
 
 	"github.com/roadrunner-server/velox/v2025"
@@ -119,7 +119,7 @@ func setup(version string) *Builder {
 
 	for _, v := range b.modules {
 		_ = os.Mkdir(v.Replace, rights)
-		_ = os.WriteFile(path.Join(v.Replace, goModStr), associated[v.ModuleName], rights)
+		_ = os.WriteFile(filepath.Join(v.Replace, goModStr), associated[v.ModuleName], rights)
 	}
 
 	return b

builder/builder_test.go

@@ -31,7 +31,6 @@ require (
 )
 
 replace (
-	github.com/uber-go/tally/v4 => github.com/uber-go/tally/v4 v4.1.10
 	{{range $v := .Entries}}{{if (ne $v.Replace "")}}{{$v.Module}} => {{$v.Replace}}
 	{{end}}{{end}}
 )

builder/templates/templateV2025.go

@@ -6,12 +6,12 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"path"
+	"path/filepath"
 	"strings"
 	"sync"
 	"time"
 
-	"github.com/google/go-github/v71/github"
+	"github.com/google/go-github/v74/github"
 	"github.com/roadrunner-server/velox/v2025"
 	"go.uber.org/zap"
 )
@@ -76,7 +76,7 @@ func (p *processor) run() {
 				rc, resp, err := p.client.Repositories.DownloadContents(context.Background(),
 					v.pluginCfg.Owner,
 					v.pluginCfg.Repo,
-					path.Join(v.pluginCfg.Folder, gomod), &github.RepositoryContentGetOptions{Ref: v.pluginCfg.Ref},
+					filepath.Join(v.pluginCfg.Folder, gomod), &github.RepositoryContentGetOptions{Ref: v.pluginCfg.Ref},
 				)
 				if err != nil {
 					p.appendErr(err)

gen/go/api/request/v1/request.pb.go

@@ -9,11 +9,10 @@ import (
 	"io"
 	"net/http"
 	"os"
-	"path"
 	"path/filepath"
 	"strings"
 
-	"github.com/google/go-github/v71/github"
+	"github.com/google/go-github/v74/github"
 	"github.com/roadrunner-server/velox/v2025"
 	"go.uber.org/zap"
 	"golang.org/x/oauth2"
@@ -82,7 +81,7 @@ func (r *GHRepo) DownloadTemplate(tmp, version string) (string, error) { //nolin
 	// replace '/' in the branch name or tag with the '_' to prevent using '/' as a path separator
 	version = strings.ReplaceAll(version, "/", "_")
 
-	name := path.Join(tmp, "roadrunner-server-"+version)
+	name := filepath.Join(tmp, "roadrunner-server-"+version)
 	_ = os.RemoveAll(name)
 
 	r.log.Debug("saving repository in temporary folder", zap.String("path", name+zipExt))

github/pool.go

@@ -7,7 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"path"
+	"path/filepath"
 	"strings"
 	"time"
 
@@ -49,7 +49,7 @@ func (r *GLRepo) GetPluginsModData() ([]*velox.ModulesInfo, error) {
 			return nil, errors.New("ref can't be empty")
 		}
 
-		file, resp, err := r.client.RepositoryFiles.GetFile(v.Repo, path.Join(v.Folder, "go.mod"), &gitlab.GetFileOptions{
+		file, resp, err := r.client.RepositoryFiles.GetFile(v.Repo, filepath.Join(v.Folder, "go.mod"), &gitlab.GetFileOptions{
 			Ref: toPtr(v.Ref),
 		})
 		if err != nil {