fix: improve symlink cleanup (#211)

Author: sammcj

main.go

@@ -98,7 +98,7 @@ var Version string // Version is set by the build system
 
 func main() {
 	if Version == "" {
-		Version = "1.35.1"
+		Version = "1.36.0"
 	}
 
 	cfg, err := config.LoadConfig()

operations.go

@@ -845,6 +845,70 @@ func isValidSymlink(symlinkPath, targetPath string) bool {
 	return true
 }
 
+// isGollamaSymlink checks if a symlink was created by gollama by validating:
+// 1. The symlink target points to Ollama's blob storage
+// 2. The directory structure follows gollama's pattern (author/model/file.gguf)
+func isGollamaSymlink(symlinkPath, lmStudioModelsDir string) bool {
+	// Get the symlink target
+	target, err := os.Readlink(symlinkPath)
+	if err != nil {
+		return false
+	}
+
+	// Check if target points to Ollama blob storage
+	// Normalise path separators for cross-platform compatibility
+	normalisedTarget := filepath.ToSlash(target)
+	isOllamaBlob := strings.Contains(normalisedTarget, "/.ollama/models/blobs/")
+
+	if !isOllamaBlob {
+		return false
+	}
+
+	// Check if it follows gollama's directory structure: author/model/file.gguf
+	relPath, err := filepath.Rel(lmStudioModelsDir, symlinkPath)
+	if err != nil {
+		return false
+	}
+
+	pathParts := strings.Split(filepath.ToSlash(relPath), "/")
+	if len(pathParts) != 3 {
+		return false
+	}
+
+	// Check if the filename follows gollama's pattern
+	filename := pathParts[2]
+	modelDir := pathParts[1]
+
+	// Gollama creates files like: modelname.gguf or mmproj-modelname.gguf
+	return strings.HasSuffix(filename, ".gguf") &&
+		(strings.HasPrefix(filename, modelDir) || strings.HasPrefix(filename, "mmproj-"+modelDir))
+}
+
+// isBrokenSymlink checks if a symlink is broken (target doesn't exist)
+func isBrokenSymlink(symlinkPath string) bool {
+	target, err := os.Readlink(symlinkPath)
+	if err != nil {
+		// Only treat as broken if the symlink itself doesn't exist
+		if os.IsNotExist(err) {
+			return true
+		}
+		// For permission errors or other issues, don't consider it broken
+		logging.DebugLogger.Printf("Error reading symlink %s: %v (not considering broken)\n", symlinkPath, err)
+		return false
+	}
+
+	// Check if target exists
+	_, err = os.Stat(target)
+	if err == nil {
+		return false // Target exists, symlink is not broken
+	}
+	if os.IsNotExist(err) {
+		return true // Target does not exist, symlink is broken
+	}
+	// For other stat errors (permission, etc.), don't consider broken
+	return false
+}
+
 func cleanBrokenSymlinks(lmStudioModelsDir string) {
 	err := filepath.Walk(lmStudioModelsDir, func(path string, info os.FileInfo, err error) error {
 		if err != nil {
@@ -863,12 +927,10 @@ func cleanBrokenSymlinks(lmStudioModelsDir string) {
 				}
 			}
 		} else if info.Mode()&os.ModeSymlink != 0 {
-			linkPath, err := os.Readlink(path)
-			if err != nil {
-				return err
-			}
-			if !isValidSymlink(path, linkPath) {
-				logging.InfoLogger.Printf("Removing invalid symlink: %s\n", path)
+			// Only remove truly broken symlinks (where target doesn't exist)
+			// Don't remove valid symlinks from other tools
+			if isBrokenSymlink(path) {
+				logging.InfoLogger.Printf("Removing broken symlink: %s\n", path)
 				err = os.Remove(path)
 				if err != nil {
 					return err
@@ -992,10 +1054,28 @@ func cleanupSymlinkedModels(lmStudioModelsDir string) {
 					hasEmptyDir = true
 				}
 			} else if info.Mode()&os.ModeSymlink != 0 {
-				logging.InfoLogger.Printf("Removing symlinked model: %s\n", path)
-				err = os.Remove(path)
-				if err != nil {
-					return err
+				// Only remove symlinks that are either:
+				// 1. Created by gollama, or
+				// 2. Broken (safe to remove)
+				shouldRemove := false
+				reason := ""
+
+				if isBrokenSymlink(path) {
+					shouldRemove = true
+					reason = "broken symlink"
+				} else if isGollamaSymlink(path, lmStudioModelsDir) {
+					shouldRemove = true
+					reason = "gollama-created symlink"
+				}
+
+				if shouldRemove {
+					logging.InfoLogger.Printf("Removing %s: %s\n", reason, path)
+					err = os.Remove(path)
+					if err != nil {
+						return err
+					}
+				} else {
+					logging.DebugLogger.Printf("Preserving non-gollama symlink: %s\n", path)
 				}
 			}
 			return nil