linting and adding requirements

Author: snhobbs

.github/workflows/python-app.yml

@@ -26,14 +26,13 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install flake8 pytest
+        python -m pip install .
+        pip install ruff pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
     - name: Lint with flake8
       run: |
         # stop the build if there are Python syntax errors or undefined names
-        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        ruff check --exit-non-zero-on-fix
     - name: Test with pytest
       run: |
         pytest

requirements.txt

@@ -1,3 +1,4 @@
 pandas
 numpy
 scipy
+pydantic

src/pulse_transitions/common.py

@@ -1,9 +1,7 @@
 from enum import Enum
-from enum import StrEnum
 from typing import Tuple
 
 from pydantic import BaseModel
-from pydantic import Extra
 from pydantic import model_validator
 
 
@@ -13,10 +11,11 @@ class EdgeSign(Enum):
     none = 0
 
 class StrictBaseModel(BaseModel):
-    class Config:
-        extra = Extra.forbid  # No extra fields allowed
+    model_config = {
+        "extra": "forbid"  # Disallow extra fields
+    }
 
-class GroupStrategy(StrEnum):
+class GroupStrategy(Enum):
     median = "median"
     mode = "mode"
     first = "first"

src/pulse_transitions/impl.py

@@ -444,7 +444,7 @@ def _detect_edge_wrapper(sign: EdgeSign, x: NumberIterable, fs: Optional[float]=
 
     return _detect_first_edge(x=t_uniform, y=x_uniform,
                              thresholds=edge_thresholds,
-                             sign=sign, settings=settings)
+                             sign=sign)
 
 
 def _calculate_thresholds(x: NumberIterable, y: NumberIterable,