fix(routing): static redirect with prerendered route (#14170)

Co-authored-by: ascorbic <[email protected]>

Author: ematipico

.changeset/rude-sites-heal.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes an issue where static redirects couldn't correctly generate a redirect when the destination is a prerendered route, and the `output` is set to `"server"`.

packages/astro/src/core/routing/manifest/create.ts

@@ -509,10 +509,20 @@ export async function createRoutesList(
 	for (const route of routes) {
 		promises.push(
 			limit(async () => {
-				if (route.type !== 'page' && route.type !== 'endpoint') return;
+				if (route.type !== 'page' && route.type !== 'endpoint' && route.type !== 'redirect') return;
+				// External redirects aren't taken into account
+				if (route.type === 'redirect' && !route.redirectRoute) return;
 				const localFs = params.fsMod ?? nodeFs;
 				const content = await localFs.promises.readFile(
-					fileURLToPath(new URL(route.component, settings.config.root)),
+					fileURLToPath(
+						new URL(
+							// The destination redirect might be a prerendered
+							route.type === 'redirect' && route.redirectRoute
+								? route.redirectRoute.component
+								: route.component,
+							settings.config.root,
+						),
+					),
 					'utf-8',
 				);
 

packages/astro/src/core/routing/manifest/prerender.ts

@@ -16,6 +16,9 @@ export async function getRoutePrerenderOption(
 	const match = PRERENDER_REGEX.exec(content);
 	if (match) {
 		route.prerender = match[1] === 'true';
+		if (route.redirectRoute) {
+			route.redirectRoute.prerender = match[1] === 'true';
+		}
 	}
 
 	await runHookRouteSetup({ route, settings, logger });

packages/astro/test/fixtures/redirects/src/pages/more/[dynamic]/[prerender].astro

@@ -0,0 +1,10 @@
+---
+export const prerender = true;
+
+export function getStaticPaths() {
+  return [{ params: { dynamic:'hello', prerender:'world' } }]
+}
+---
+{JSON.stringify(Astro.params)}
+
+<a href="/">home</a>

packages/astro/test/redirects.test.js

@@ -21,6 +21,8 @@ describe('Astro.redirect', () => {
 					'/source/[dynamic]': '/not-verbatim/target1/[dynamic]',
 					// may be called src/pages/not-verbatim/target2/[abc]/[xyz].astro
 					'/source/[dynamic]/[route]': '/not-verbatim/target2/[dynamic]/[route]',
+					// check for prerendered routes
+					'/source/[dynamic]/[prerender]': '/not-verbatim/target2/[dynamic]/[prerender]',
 					// may be called src/pages/not-verbatim/target3/[...rest].astro
 					'/source/[...spread]': '/not-verbatim/target3/[...spread]',
 				},