Migrate ecsacs.Task's Attachments

Author: Thean Lim

agent/acs/session/payload_responder_test.go

@@ -695,7 +695,7 @@ func TestHandlePayloadMessageAddedEBSToTask(t *testing.T) {
 					},
 				},
 			},
-			Attachments: []*acstypes.Attachment{
+			Attachments: []acstypes.Attachment{
 				{
 					AttachmentArn: aws.String("attachmentArn"),
 					AttachmentProperties: []acstypes.AttachmentProperty{

agent/api/task/task_attachment_handler.go

@@ -82,11 +82,12 @@ func handleTaskAttachments(acsTask *ecsacs.Task, task *Task) error {
 		var serviceConnectAttachment *acstypes.Attachment
 		var ebsVolumeAttachments []*acstypes.Attachment
 		for _, attachment := range acsTask.Attachments {
+			attachmentPtr:= &attachment
 			switch aws.ToString(attachment.AttachmentType) {
 			case serviceConnectAttachmentType:
-				serviceConnectAttachment = attachment
+				serviceConnectAttachment = attachmentPtr
 			case apiresource.EBSTaskAttach:
-				ebsVolumeAttachments = append(ebsVolumeAttachments, attachment)
+				ebsVolumeAttachments = append(ebsVolumeAttachments, attachmentPtr)
 			default:
 				logger.Debug("Received an attachment type", logger.Fields{
 					"attachmentType": attachment.AttachmentType,

agent/api/task/task_attachment_handler_test.go

@@ -164,7 +164,7 @@ func TestHandleTaskAttachmentsWithServiceConnectAttachment(t *testing.T) {
 				Containers: []*ecsacs.Container{
 					getTestcontainerFromACS(testSCContainerName, AWSVPCNetworkMode),
 				},
-				Attachments: []*acstypes.Attachment{
+				Attachments: []acstypes.Attachment{
 					{
 						AttachmentArn: stringToPointer("attachmentArn"),
 						AttachmentProperties: []acstypes.AttachmentProperty{
@@ -244,7 +244,7 @@ func TestHandleTaskAttachmentWithEBSVolumeAttachment(t *testing.T) {
 				Containers: []*ecsacs.Container{
 					getTestcontainerFromACS(testSCContainerName, AWSVPCNetworkMode),
 				},
-				Attachments: []*acstypes.Attachment{
+				Attachments: []acstypes.Attachment{
 					{
 						AttachmentArn: stringToPointer("attachmentArn"),
 						AttachmentProperties: []acstypes.AttachmentProperty{

agent/api/task/task_test.go

@@ -4676,7 +4676,7 @@ func TestTaskServiceConnectAttachment(t *testing.T) {
 					containerFromACS("C1", 33333, 0, tc.testNetworkMode),
 					containerFromACS(serviceConnectContainerTestName, 0, 0, tc.testNetworkMode),
 				},
-				Attachments: []*acstypes.Attachment{
+				Attachments: []acstypes.Attachment{
 					{
 						AttachmentArn: strptr("attachmentArn"),
 						AttachmentProperties: []acstypes.AttachmentProperty{
@@ -4749,7 +4749,7 @@ func TestTaskWithEBSVolumeAttachment(t *testing.T) {
 				},
 			},
 		},
-		Attachments: []*acstypes.Attachment{
+		Attachments: []acstypes.Attachment{
 			{
 				AttachmentArn: strptr("attachmentArn"),
 				AttachmentProperties: []acstypes.AttachmentProperty{