Support fieldIndex in VDBs #2394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utodesk#2316) Translator is still WIP (cherry picked from commit bb77b6e) (cherry picked from commit 9adaa59)
(cherry picked from commit 842eca8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR includes the changes previously pushed in #2316 that were reverted. It also includes a support of fieldIndex in regular vdb translation, both in usd and hydra. It also adds a test_2315 with that use case.
It's marked as a draft as I still don't have something satisfying, at the moment I'm only supporting the field index if it is > 0 which is not really the intended behaviour. Problem is that the default value of fieldIndex is 0, so if we always take it into account it would end up changing the code path for all vdb renders, in a way that would break existing scenes.
Issues fixed in this pull request
Fixes #2315