Support resolutions with a different aspect ratio than the data window #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
We receive render resolution through 2 different ways : a "resolution" render setting and the dataWindow's widht & height.
In general, they are both identical, but in the case of Solaris clone render, they can be different. We get a default 1920x1080 data window resolution, but with the resolution specified in the render settings.
In that case, we still need to render for the data window resolution (that's the size of the output buffers that need to be filled), but the image will then be modified to be in the render settings resolution. The only solution is to adjust the pixel aspect ratio in that case, so that we get the expected result.
Setting this PR as a draft until we confirm that we want to go ahead with that fix
Issues fixed in this pull request
Fixes HTOA-2793
Additional context
Add any other context or screenshots about the pull request here.