windows: add ltsc releases as default bases #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
windows_default_multi
branch
3 times, most recently
from
dc0c409 to
b2ee90f
Compare
cpuguy83
changed the title
This makes it so that, by default, windowscross/container will build for all current ltsc releases. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
windows_default_multi
branch
from
b2ee90f to
998b17a
Compare
cpuguy83
commented
Mar 22, 2025
| @@ -22,10 +22,21 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| defaultBaseImage = "mcr.microsoft.com/windows/nanoserver:1809" | |||
| winltsc2019 = "mcr.microsoft.com/windows/nanoserver:ltsc2019" | |||
There was a problem hiding this comment.
Note: ltsc2019 and 1809 are the same images.
There was a problem hiding this comment.
maybe add a comment about this?
adamperlin
reviewed
Apr 11, 2025
There was a problem hiding this comment.
@cpuguy83 it looks like there are some CI failures, possibly to do with an image config issue?
Failures are due to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that, by default, windowscross/container will build for
all current ltsc releases.