Prebuild worker images #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
prebuild_worker_images
branch
4 times, most recently
from
655566b to
704813d
Compare
cpuguy83
force-pushed
the
prebuild_worker_images
branch
7 times, most recently
from
f48b0ea to
230fcef
Compare
|
What does the following mean, from the 2nd commit message?
What does it mean to "load routes"? What do you mean by "build routes". I don't understand what the 2nd commit is doing |
|
"routes" => build targts ( |
|
Can you explain how the containerd plugin system is being used here, and what it does generally? What does it mean to "load" a route/build target via a plugin? |
pmengelbert
reviewed
Jun 27, 2025
| import ( | ||
| "context" | ||
|
|
||
| "github.com/moby/buildkit/frontend/gateway/client" |
There was a problem hiding this comment.
I would alias this to gwclient since we do that almost everywhere else. Makes it clearer faster which client is being used
pmengelbert
reviewed
Jun 27, 2025
pmengelbert
reviewed
Jun 27, 2025
pmengelbert
reviewed
Jun 27, 2025
pmengelbert
reviewed
Jun 27, 2025
This makes usse of the containerd plugin system to add support for loading routes via plugin. This can be expanded to more than just build routes, but this is useful for now. I plan to use this more in a follow-up commit. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
prebuild_worker_images
branch
from
230fcef to
68e5d58
Compare
This will be triggered on merge to populate the worker cache which can be used by CI jobs. It will also be triggered on tag pushes which will ensure each release of dalec will give us a set of worker images that can be used as base images for other projects. workflow_dispatch is also included for rebuilding images manually. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
prebuild_worker_images
branch
from
68e5d58 to
b2beabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-built worker images to ghcr repo.
These get pushed on tag, but also create a GHA cache on merge.
Builders can either use
--cache-fromwith the image ref for the versioned worker to use it as a cache for building the worker image OR use--build-context <worker-name>=<worker image ref>just use the worker image outright.